fvogt added a comment.
In https://phabricator.kde.org/D9072#189550, @mkoller wrote: > In https://phabricator.kde.org/D9072#189303, @fvogt wrote: > > > Looks good to me, but I wonder whether > > > > > KWallet writes an error to stderr when a 0-winId is given to openWallet() which is received by git-lfs and aborts the operation. > > > > should be fixed more in a more general way as well. > > > Like how ? Duping stdout/stderr to new file descriptors, using those and closing 1/2 would be very effective. Does kwallet really write to stderr? If so, why does git-lfs parse stderr in addition to stdout? REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9072 To: mkoller, cfeck, jriddell, whiting Cc: fvogt, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
