Ok, then QtWayland 5.9.2, but not Qt 5.9.2
Am 2. November 2017 05:56:11 MEZ schrieb Bhushan Shah :
>On Wed, Nov 01, 2017 at 09:21:50PM +0100, Martin Flöser wrote:
>> As you are on Debian: make sure you get Qt 5.9.2. Debian testing
>currently
>> only has Qt 5.9.1 and there are important fixes. Best
On Wed, Nov 01, 2017 at 09:21:50PM +0100, Martin Flöser wrote:
> As you are on Debian: make sure you get Qt 5.9.2. Debian testing currently
> only has Qt 5.9.1 and there are important fixes. Best would be to get the
> latest patches for QtWayland of the 5.9 branch. I'm currently running a self
> co
anthonyfieroni added inline comments.
INLINE COMMENTS
> kastatsfavoritesmodel.cpp:506
> {
> return d->trigger(row, actionId, argument);
> }
d && d->trigger ?
> kastatsfavoritesmodel.cpp:622
> {
> const auto url = d->normalizedId(id).value();
>
addFavorite has a check, so here it
On Wed, Nov 01, 2017 at 08:08:26PM +0100, Matthias Klumpp wrote:
> Performance isn't great at all at the moment (and stability also
> isn't, it crashes as soon as I try to pull down the top drawer)
That is... known bug, can you please try to uninstall the
kwayland-integration? That would solve th
xuetianweng added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8529
To: xuetianweng, apol, mart, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
xuetianweng added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8460
To: xuetianweng, subdiff, davidedmundson, ngraham, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:fac2fafc9930: Make tooltips in klipper settings dialog
translatable (authored by lueck).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8453?vs=21254&id=21
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8611
To: davidedmundson, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
ab
apol accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8609
To: davidedmundson, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, seb
davidedmundson edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8611
To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
And get rid of a weird DEBUG macro with formatting.
If a dev wants a QT_MESSAGE_PATTERN they
davidedmundson created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
TEST PLAN
Compiles
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8609
AFFECTED FILES
applets/kick
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
KAStatsFavouritesModel doesn't initialise a D-pointer for the lifespan
of the KAStatsFavourit
ngraham added a comment.
I would love to, and in general I do, but I do all my development in a VM,
and my Neon VM doesn't expose a brightness setting, which is the control that
inappropriately appears on top without this change. So the before-and-after
wouldn't be very exciting. :) If anyon
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Generally, if we have a UI change can we include a screenshot - the one thing
we really need to improve is the VDG being in continual feedback loops with
regards to changes.
ngraham added a reviewer: mck182.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8607
To: ngraham, #plasma_workspaces, broulik, mck182
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham added reviewers: Plasma: Workspaces, broulik.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8607
To: ngraham, #plasma_workspaces, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 345940
Move the "Enable Power Management" checkbox to the top of the window to match
other applets (bluetooth, network)
REPOSITORY
Am 2017-11-01 20:08, schrieb Matthias Klumpp:
This makes complete sense. I didn't know that there was such as thing
as a mouse cursor layer (why would the cursor be special?). When
running Weston, I do get a cursor though, so I guess it's using some
kind of emulation.
Cursor layer is quite norm
2017-10-31 10:22 GMT+01:00 Martin Flöser :
> Am 2017-10-31 02:56, schrieb Matthias Klumpp:
>>
>> Hello!
>> For a phone we obviously don't need a mouse pointer, but at the moment
>> I can only interact with the UI by clicking blindly, which is not
>> ideal for testing. So, do you have an idea on wha
ngraham added a comment.
FWIW, I do approve of the goal here. I can't imagine that any more than a
very very tiny fraction of all drags to the desktop or into a web browser or
text editor window are intentional.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/
graesslin added a comment.
In https://phabricator.kde.org/D8594#163068, @graesslin wrote:
> I tried rotating the cursor plane: that does not help unfortunately.
Which is no surprise, the API seems not to use atomic commits, so it just
never gets populated.
REPOSITORY
R108 KWin
graesslin added a comment.
I tried rotating the cursor plane: that does not help unfortunately.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8594
To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezh
graesslin added dependencies: D8578: [platforms/drm] Forward the mode changes
to the OutputInterface, D8582: [platforms/drm] Add support for rotation
property on the Plane.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8602
To: graesslin, #kwin, #plasma, subdiff
Cc: pla
graesslin added a dependent revision: D8602: [platforms/drm] Restore previous
mode if an atomic test fails.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8578
To: graesslin, #kwin, #plasma
Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,
ali-moham
graesslin added a dependent revision: D8602: [platforms/drm] Restore previous
mode if an atomic test fails.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8582
To: graesslin, #kwin, #plasma, subdiff
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, leslie
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, subdiff.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
When KWin successfully presents a new mode, it stores the current state
as the last wo
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:fc887ab90788: Render GL Window decorations at the correct
scale (authored by davidedmundson).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D8600?vs=21719&id=21723#toc
REPOSITORY
R108 KWin
emateli added a comment.
> Task Manager items are not widgets, it's content, and the widget mutability
state should not affect content drags.
I don't see why it can't. Task manager items can be aware of the panel state
if that's needed.
> "If widgets are locked, stop adding a certai
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b3044152a31c: Avoid blocking DBus calls when extracting
files (authored by davidedmundson).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8601?vs=21721&id=2
graesslin accepted this revision.
graesslin added a comment.
This revision is now accepted and ready to land.
nice :-)
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8600
To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, kwin, #kwin,
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8601
To: davidedmundson, #plasma, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber
graesslin added a comment.
In https://phabricator.kde.org/D8594#162948, @davidedmundson wrote:
> > Furthermore this only implements the visual rotation and not the input
rotation.
>
> For mouse I think this is the correct behaviour. If I flip a monitor, I
would expect moving the mous
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When copying from Ark to the desktop we make a blocking DBus call,
freezing the entire UI unt
broulik added a comment.
This looks fishy. From `QObject::connect()` docs:
> The connection will automatically disconnect if the sender or the context
is destroyed.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: broulik, ant
anthonyfieroni added a comment.
Are sure about that? Every connection is destroyed when sender or receiver
dies i.e. when dropjob dies connection also, no?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: anthonyfieroni, plasma-dev
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
Under wayland we support high DPI putting by putting a separation
between the logica
broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> foldermodel.cpp:981
>
> -QPoint pos;
> -pos.setX(dropEvent->property("x").toInt());
> -pos.setY(dropEvent->property("y").toInt());
> -
> +QPoint pos
anthonyfieroni added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8596
To: mwolff, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mwolff added a comment.
So far, mostly food for thought. It kinda works but I see lots of problems
with this approach... I'll investigate other approaches tomorrow
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff, hein, amantia
Cc: plasma-devel
mwolff added a reviewer: amantia.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mwolff added a reviewer: hein.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mwolff created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Remember the drop target position and move the items once they
become available. This requires us to allow moving while no
drag image is bei
mwolff created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
BRANCH
wip/lim-2
REVISION DETAIL
https://phabricator.kde.org/D8597
AFFECTED FILES
containments/desktop/plugins/folder/fol
mwolff created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When handling a drop event, a drop job was created and a
Qt signal/slot connection created. This connection was only
freed once the model ge
amantia updated this revision to Diff 21711.
amantia added a comment.
Added unit test for ScreenMapper and improve the code to cover all the cases
tested.
Added asserts instead of disconnects.
Change the ScreenMapper API completely to QString (from QUrl) as that is what
is more natural (w
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:e7b183f886fb: Load QtQuick settings (authored by
davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8040?vs=20051&id=21708
REVISION DETAIL
https://phab
amantia edited the summary of this revision.
amantia added dependencies: D8567: Emit signals when a screen is added or
removed, D8566: Add API to retrieve the screen id for a screen name.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma,
amantia added a dependent revision: D8493: Make Folder View screen aware.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliez
amantia added a dependent revision: D8493: Make Folder View screen aware.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Cc: broulik, plasma-devel, dhaumann, apol, #frameworks,
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:54b36325f717: Support software QtQuickRendering in
Aurorae (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8039?vs=21699&id=21707
REVISIO
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:ca6459145c71: Remove code duplication (authored by
davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8581?vs=21658&id=21709
REVISION DETAIL
https://ph
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:449c93362b9a: Only cleanup XRenderUtils is we actually
created it (authored by davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8593?vs=21700&id=21710
mwolff added a comment.
small nits, plus the asserts from the previous review. otherwise lgtm - the
plasma people should chime in
INLINE COMMENTS
> foldermodel.cpp:1314
> +const QUrl url = item.url();
> +const int screen = m_screenMapper->screenForUrl(url);
> +// don
mwolff added inline comments.
INLINE COMMENTS
> amantia wrote in foldermodel.cpp:1671
> Done, although the screenmapper will never change.
an assert would be valid in such a scenario
> amantia wrote in foldermodel.cpp:1704
> From my understanding, this setAppletInterface is called only once whe
davidedmundson added a comment.
> Furthermore this only implements the visual rotation and not the input
rotation.
For mouse I think this is the correct behaviour. If I flip a monitor, I would
expect moving the mouse up should make it go down.
This means mouse movement and touch input
ngraham added a comment.
> The code depends on:
> https://phabricator.kde.org/D8566
> https://phabricator.kde.org/D8567
The correct way to write this is:
Depends on D8566
Depends on D8567
That way, those patches will be automatically added to the "stack" and those
pa
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8039
To: davidedmundson, #plasma, graesslin
Cc: graesslin, apol, plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff,
leslie
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R108 KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8593
To: davidedmundson, #plasma, graesslin
Cc: plasma-devel, kwin, #kwin, bwowk, ZrenBot, progwolff, lesliezhai,
ali-mohamed
graesslin added a dependent revision: D8594: [platforms/drm] Rotate screen if
requested from KScreen.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8582
To: graesslin, #kwin, #plasma, subdiff
Cc: davidedmundson, plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai,
graesslin added a dependency: D8582: [platforms/drm] Add support for rotation
property on the Plane.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D8594
To: graesslin, #kwin, #plasma, subdiff, sebas
Cc: plasma-devel, kwin, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohame
graesslin created this revision.
graesslin added reviewers: KWin, Plasma, subdiff, sebas.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
This change hooks up the drm plane rotate with the rotation requests
from KScre
amantia edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol
Cc: mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff,
lesli
amantia updated this revision to Diff 21703.
amantia added a comment.
Fix Milian's comments, simplify/merge ScreenMapper add/remove screen methods.
Treat folderview destruction as screen removal, as it has the same effects.
Makes the code work correctly
when the containment changes from Fo
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in foldermodel.cpp:1671
> missing disconnect on the old mapper for the invalidate filter
Done, although the screenmapper will never change.
> mwolff wrote in foldermodel.cpp:1704
> when the interface changes, don't you need to discon
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: KWin, kwin, plasma-devel.
REVISION SUMMARY
BUG: 386430
TEST PLAN
kwin_x11 --crashes 20
Got a dialog. Hit cancel. It didn't c
mwolff added a comment.
lgtm, but the plasma people should chime in now, esp. regarding what @apol
said
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart, davidedmundson, plasma-
davidedmundson updated this revision to Diff 21699.
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Avoid all GL in software mode.
Had a bit of a reshuffle to create the view first, so we can use the
graphicsAPI from that
rather than t
mwolff added inline comments.
INLINE COMMENTS
> foldermodel.cpp:1671
> +return;
> +
> +m_screenMapper = screenMapper;
missing disconnect on the old mapper for the invalidate filter
> foldermodel.cpp:1704
> +setScreen(containment->screen());
> +
ngraham added a dependent revision: D8592: Update default colors to match new
colors in D7424.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7424
To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg
Cc: abetts, januz, progwolff, broulik, sebas, plasma
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in foldermodel.cpp:1316
> adding some comment here would help people reading the code in the future.
> I.e. something like "exclude items that are shown on a different screen"
>
> also, I personally think this code is not pretty at a
amantia edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol
Cc: mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff,
lesli
amantia updated this revision to Diff 21696.
amantia marked 8 inline comments as done.
amantia added a comment.
Handle screen associated in C++ part (no need to go through QML now), fix
issues mentioned by Milian.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricat
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8453
To: lueck, #plasma, ltoscano, davidedmundson
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterber
lueck added a reviewer: ltoscano.
lueck added a comment.
Please review, thanks
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8453
To: lueck, #plasma, ltoscano
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, ap
subdiff added a comment.
In https://phabricator.kde.org/D8564#162797, @emateli wrote:
> I feel like the long press can mess with the manual ordering of task
manager icons.
**Short press**
Press -> start timer
release -> single click on task
timer stops
Press -> start
davidedmundson added a comment.
Sounds like we want what is something similar to
https://phabricator.kde.org/R296:86bbebdee213f08ae615d7459304cbd17f6b7d7d in
kdeclarative's DragArea
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-dev
emateli added a comment.
I feel like the long press can mess with the manual ordering of task manager
icons.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel, #plasma
Cc: subdiff, hein, plasma-devel, ZrenBot, progwolff, lesliezha
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7af16dc48fa0: Folder View icons properties: Improve
visual layout (authored by marten).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8563?vs=21601&id=21691
subdiff added a comment.
That said accidental drags from the task manager are really a common issue.
Could we do some sort of double-tap-and-drag instead of just drag to minimize
the risk for an accidental drag?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/
hein added a comment.
I still don't like it, sorry - the patch also feels technically and
semantically wrong to me. "If widgets are locked, stop adding a certain kind of
data to the drag" is a pretty bad hack.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8
emateli added a comment.
Hi @hein, thanks for your input and I understand that this might break some
functionality that I'm unaware of (such as the drop of task manager icons into
the pager widget).
The current revision allows drop into the pager widget and other plasma
widgets(needs mo
emateli updated this revision to Diff 21689.
emateli added a comment.
Remove empty line
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8564?vs=21688&id=21689
BRANCH
disable-drop
REVISION DETAIL
https://phabricator.kde.org/D8564
AFFECTED FILES
emateli updated this revision to Diff 21688.
emateli added a comment.
Allow task items to be dropped onto other widgets
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8564?vs=21606&id=21688
BRANCH
disable-drop
REVISION DETAIL
https://phabricato
broulik added a comment.
FYI: This then also needs to be adjusted in `kcolorschene.cpp` in
KConfigWidgets
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D7424
To: ngraham, hpereiradacosta, jensreuterberg, jriddell, kvermette, #vdg
Cc: abetts, januz, progwolff, broulik
hein added a comment.
As-is I would not accept this patch, I'm sorry. Task Manager items are not
widgets, it's content, and the widget mutability state should not affect
content drags.
This particular drag is used for workspace features some people do rely on,
e.g.:
- moving a wind
amantia retitled this revision from "Return the screen id for a screen name."
to "Emit signals when a screen is added or removed".
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart,
amantia updated this revision to Diff 21687.
amantia added a comment.
Remove unneeded changed
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8567?vs=21686&id=21687
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8567
AFFECTED FILE
emateli added a reviewer: Plasma.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8564
To: emateli, plasma-devel, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
mwolff added a comment.
some code review from my side
INLINE COMMENTS
> foldermodel.cpp:77
> #include
> +#include
> +#include
wrong location of include, and the KF5 prefix is wrong too, I guess?
> foldermodel.cpp:1314
> +
> +const QString name = item.url().toString();
> +if (m_u
mwolff added inline comments.
INLINE COMMENTS
> shellcorona.cpp:1161
>
> -if (DesktopView* v = desktopForScreen(screen))
> +if (DesktopView* v = desktopForScreen(screen)) {
> removeDesktop(v);
now you can undo this hunk
REPOSITORY
R120 Plasma Workspa
davidedmundson accepted this revision.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Cc: broulik, plasma-devel, dhaumann, apol, #frameworks, ZrenBot, progwolff,
lesliezhai, al
amantia updated this revision to Diff 21686.
amantia added a comment.
Emit the screenRemoved from within removeDesktop
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8567?vs=21683&id=21686
BRANCH
master
REVISION DETAIL
https://phabricator.kde
amantia marked an inline comment as done.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg
mwolff added inline comments.
INLINE COMMENTS
> shellcorona.cpp:1162
> removeDesktop(v);
> +emit screenRemoved(m_screenPool->id(screen->name()));
> +}
shouldn't this be done from within `removeDesktop`? considering this duplicates
the change above?
amantia abandoned this revision.
amantia added a comment.
Created by mistake, right one is https://phabricator.kde.org/D8493
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8589
To: amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu
amantia updated this revision to Diff 21685.
amantia added a comment.
Use the plasma signals with screen id instead of QGuiApplication signals with
the QScreen objects.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21619&id=21685
BRANCH
amantia added a reviewer: apol.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol
Cc: davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, j
amantia added a comment.
I have changed the code to not rely on screen removal/addition signals inside
the FolderView plugin, but use the existing code from shellcorona. This also
ensures that we get the signals for the right id, and works correctly as long
as the screen layout detection in
amantia created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- store a map of url/screen ids in the configuration file
- have a central mapping object shared by all folder views
- if the model is used
1 - 100 of 108 matches
Mail list logo
