amantia updated this revision to Diff 21711. amantia added a comment.
Added unit test for ScreenMapper and improve the code to cover all the cases tested. Added asserts instead of disconnects. Change the ScreenMapper API completely to QString (from QUrl) as that is what is more natural (we store QStrings anyway in the config file). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=21703&id=21711 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8493 AFFECTED FILES containments/desktop/package/contents/config/main.xml containments/desktop/package/contents/ui/FolderView.qml containments/desktop/package/contents/ui/FolderViewLayer.qml containments/desktop/plugins/folder/CMakeLists.txt containments/desktop/plugins/folder/autotests/CMakeLists.txt containments/desktop/plugins/folder/autotests/screenmappertest.cpp containments/desktop/plugins/folder/autotests/screenmappertest.h containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h containments/desktop/plugins/folder/folderplugin.cpp containments/desktop/plugins/folder/screenmapper.cpp containments/desktop/plugins/folder/screenmapper.h To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol Cc: ngraham, mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
