amantia updated this revision to Diff 21703. amantia added a comment.
Fix Milian's comments, simplify/merge ScreenMapper add/remove screen methods. Treat folderview destruction as screen removal, as it has the same effects. Makes the code work correctly when the containment changes from Folder View to Desktop and vice versa. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8493?vs=21696&id=21703 BRANCH master REVISION DETAIL https://phabricator.kde.org/D8493 AFFECTED FILES containments/desktop/package/contents/config/main.xml containments/desktop/package/contents/ui/FolderView.qml containments/desktop/package/contents/ui/FolderViewLayer.qml containments/desktop/plugins/folder/CMakeLists.txt containments/desktop/plugins/folder/foldermodel.cpp containments/desktop/plugins/folder/foldermodel.h containments/desktop/plugins/folder/folderplugin.cpp containments/desktop/plugins/folder/screenmapper.cpp containments/desktop/plugins/folder/screenmapper.h To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson, apol Cc: mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
