Re: Working on improvements to QuickShare

> > FWIW, I have a bit of a todo list here, we can discuss things WRT the > plasmoid if you want. Sounds great! I'm all ears :) How about implementing smarter sorting and keyboard support? > I'm not fond of "Remember" options because they add complexity and > make it hard to get back to the orig

[Differential] [Request, 28 lines] D4754: [kcheckpass] Drop the ACCEPT_ENV compatibility define

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Given the code comment this was just for compatibility to accept some values from the environment. The env variables KCHECKPASS_USER and

[Differential] [Request, 41 lines] D4753: [kcheckpass] Drop the throttle handling code

graesslin created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Kcheckpass has code to throttle the invocation to prevent brute force attack. This code has been broken for years and is never executed.

Re: Working on improvements to QuickShare

On Fri, Feb 24, 2017 at 3:46 AM, Aleix Pol wrote: > On Thu, Feb 23, 2017 at 6:24 PM, Yuen Hoe Lim wrote: >> Hello, >> >> I'm looking for some work to do :) and figured I could start with finding an >> itch to scratch. I'm thinking about the QuickShare plasmoid, which I'm >> currently feeling isn'

Re: Working on improvements to QuickShare

On Thu, Feb 23, 2017 at 6:24 PM, Yuen Hoe Lim wrote: > Hello, > > I'm looking for some work to do :) and figured I could start with finding an > itch to scratch. I'm thinking about the QuickShare plasmoid, which I'm > currently feeling isn't as good to use as the old Plasma4 Pastebin plasmoid. > I

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added inline comments. INLINE COMMENTS > subdiff wrote in ListItemBase.qml:283 > > Please move literal to right side > > I like to read my inequalities from lower value to higher one. Easier to read > the code this way. Besides style is there something else speaking against > that? What @

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. In https://phabricator.kde.org/D4751#89222, @Zren wrote: > Looks like the icon is really small in plasmoidviewer? Using scaling factor 2 on 4K. Have no idea why it looks this way for you. > Just wondering why you used a IconItem+MouseArea pattern for t

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:283 > Please move literal to right side of comparison: `PulseObject.ports.length > > 0` or even in this case you can just write `PulseObject.ports.length`. > > But actually make it `Ports.length` as said in previous

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. What DPI are you using SubDiff? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4751 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, drosca, Zren Cc: plasma-devel, progwo

[Differential] [Updated] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

Zren added a comment. F2562978: 2017-02-23___17-03-39.png Looks like the icon is really small in plasmoidviewer? Just wondering why you used a IconItem+MouseArea pattern for the button instead of `PlasmaComponents.ToolButton`? The positioning

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 81 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/81/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 23 Feb 2017 17:14:45 + Build duration: 32 min CHANGE SET Revision ffe7d7fab46ca968963a8dbf

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

drosca added inline comments. INLINE COMMENTS > ListItemBase.qml:137 > +source: "application-menu" > +Layout.maximumHeight: parent.height * 0.85 > +Layout.maximumWidth: Layout.maximumHeight Use Layout.preferredHeight instead

[Differential] [Request, 110 lines] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff created this revision. subdiff added a project: Plasma. REVISION SUMMARY Based on https://phabricator.kde.org/D2314. Additionally adds a button to open context menu and always shows ports in the menu (greyed out if only one available). F282: Screenshot_20170223_204846.png

[Differential] [Updated, 5 lines] D4744: ReceiveFileJob: Don't cancel the request right after accepting it

drosca updated this revision to Diff 11721. drosca added a comment. Initialize in constructor REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4744?vs=11684&id=11721 BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4744 AFFECTED FILES

[Differential] [Updated, 3 lines] D4491: Let make taskmanager tooltip readable again

anthonyfieroni updated this revision to Diff 11719. anthonyfieroni added a comment. Fix too long tooltip text REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4491?vs=11096&id=11719 REVISION DETAIL https://phabricator.kde.org/D4491 AFFECTED FILES

Re: Working on improvements to QuickShare

> Makes sense. Maybe show a notification to say it's been copied? > > Okay! Thanks. Lim Yuen Hoe, Jason (moofang) http://yuenhoe.com/

Re: Working on improvements to QuickShare

On 02/24/2017 02:24 AM, Yuen Hoe Lim wrote: > Hello, > > I'm looking for some work to do :) and figured I could start with > finding an itch to scratch. I'm thinking about the QuickShare plasmoid, > which I'm currently feeling isn't as good to use as the old Plasma4 > Pastebin plasmoid. I'm thin

[Differential] [Commented On] D4749: Fix another regression with rearranging launchers in an activities world.

hein added a comment. Note: This is a critical bug, and it's important this fix get into 5.9.3. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4749 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, davidedm

[Differential] [Commented On] D4746: Ignore drag move events if an item doesn't allow drop.

hein added a comment. Heads up: This doesn't do the same for drop events, which makes it incomplete, and doing it for drop events collides with us now relying on DropJob to get containment drop actions. This will require some more work to pass drop events on to the containment when the dir m

[Differential] [Request, 3 lines] D4749: Fix another regression with rearranging launchers in an activities world.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY The new activity-aware implementation of LauncherTasksModel::setLauncherList() would only accept the passed list when it changed any activities associations, not when the order changed. This would

Working on improvements to QuickShare

Hello, I'm looking for some work to do :) and figured I could start with finding an itch to scratch. I'm thinking about the QuickShare plasmoid, which I'm currently feeling isn't as good to use as the old Plasma4 Pastebin plasmoid. I'm thinking of working to make the following changes: 1. Ability

Re: Playing with libseccomp

Am 2017-02-19 13:17, schrieb Martin Gräßlin: But I'm not able to authenticate any more. The seccomp filter gets inherited to forked processes and cannot be disabled any more (the idea is that you cannot escape the sandbox). KScreenlocker forks+exec kcheckpass and that somehow opens a file in writ

[kio-extras] [Bug 376830] smb share in dolphin is very broken

https://bugs.kde.org/show_bug.cgi?id=376830 Mark changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[kio-extras] [Bug 376830] smb share in dolphin is very broken

https://bugs.kde.org/show_bug.cgi?id=376830 Elvis Angelaccio changed: What|Removed |Added Version|16.12.0 |unspecified Product|dolphin

[Differential] [Closed] D4617: Track the actual pressed keys in ModifierOnlyShortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit R108:4a976d58ec50: Track the actual pressed keys in ModifierOnlyShortcuts (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4617?vs=11359&id=11702 RE

[Differential] [Updated, 20 lines] D4703: move the view at the correct index at startup

mart updated this revision to Diff 11700. mart added a comment. Restricted Application edited projects, added KWin; removed Plasma. - don't export the qwidget on the qml context REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4703?vs=11590&id=11700 BRANCH ar

[Differential] [Closed] D4563: Replace warps-slider checkbox with radio buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R99:57403a78afa2: Replace warps-slider checkbox with radio buttons (authored by elvisangelaccio). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4563?v

[Differential] [Closed] D4740: Fonts KCM: Fix layout of hinting settings, port away from KDE4

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc5720494a01: Fonts KCM: Fix layout of hinting settings, port away from KDE4 (authored by marten). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4740?vs=116

[Differential] [Changed Subscribers] D4744: ReceiveFileJob: Don't cancel the request right after accepting it

marten added inline comments. INLINE COMMENTS > receivefilejob.h:69 > BluezQt::Request m_request; > +bool m_accepted = false; > }; Allowed in C++11, but would this not be clearer done in the constructor initialization list? REPOSITORY R97 Bluedevil REVISION DETAIL https://phabri

[Differential] [Closed] D4648: try harder to make the selected wallpaper visible

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ed2f9de7f4c2: try harder to make the selected wallpaper visible (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4648?vs=11450&id=11687

[Differential] [Request, 40 lines] D4746: Ignore drag move events if an item doesn't allow drop.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY This makes no difference in practice, but in theory would allow KDirModel/KIO to reject drops on non-writable locations and the like and avoids doing all the drop and DropJob work for nothing. REPOS

[Differential] [Commented On] D4703: move the view at the correct index at startup

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:102 > We can't do this. > > You've just restored the crash when hitting back. > See https://phabricator.kde.org/R108:70d2fb2378d636ef6d052da08417b27c99182fb0 aww, right, this one is a qwidget, will move it into the mo

[Differential] [Accepted] D4740: Fonts KCM: Fix layout of hinting settings, port away from KDE4

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4740 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: marten, #plasma, mart Cc: plasma-devel, progwol

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

davidedmundson added a comment. Generally good to go. Just one major gripe about Label, and making sure our installed items and qmldir are in sync. INLINE COMMENTS > CMakeLists.txt:11 > + > +#install the componenbts as a QQC2 Style, as style for applications (mainly > for Plasma Mobile) > +

[Differential] [Request, 4 lines] D4744: ReceiveFileJob: Don't cancel the request right after accepting it

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY KNotification::closed is emitted also when one of the notification actions was triggered. BUG: 376773 FIXED-IN: 5.8.7 REPOSITORY R97

[Differential] [Accepted] D4617: Track the actual pressed keys in ModifierOnlyShortcuts

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH mod-only-track-pressed-keys REVISION DETAIL https://phabricator.kde.org/D4617 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin

[Differential] [Accepted] D4648: try harder to make the selected wallpaper visible

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH phab/scrollHack REVISION DETAIL https://phabricator.kde.org/D4648 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #pl

[Differential] [Requested Changes] D4703: move the view at the correct index at startup

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kcm.cpp:102 > +//this should be the only context property > +m_quickView->rootContext()->setContextProperty(QStringLiteral("kcm"), > t

Re: KMS backlight ABI proposition

Hi, On 23-02-17 09:55, Jani Nikula wrote: On Wed, 22 Feb 2017, Hans de Goede wrote: My first thought was that your proposal is reasonable, but on second thought I foresee trouble here with e.g. the backlight level save / restore code in systemd still using the sysfs interface, while the deskto

[Differential] [Commented On] D4739: make sure the cancel action is last

dfaure added inline comments. INLINE COMMENTS > dropjob.h:38 > class DropJobPrivate; > +class DropMenu; > still here? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4739 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasm

[Differential] [Closed] D4681: [Logout Screen] Show suspend button only if supported

broulik closed this revision. broulik added a comment. https://cgit.kde.org/plasma-workspace.git/commit/?h=Plasma/5.8&id=8bc32846a5a41fa67c106045c43bb8c4af7e7e6f REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4681 EMAIL PREFERENCES https://phabricator.kd

[Differential] [Commented On] D4732: [KCM] Rework design and structure

drosca added a comment. Sorry, I only noticed it now when I was trying to fix the binding loop. INLINE COMMENTS > Applications.qml:33 > +ColumnLayout { > +width: scrollView.viewport.width > + There is now binding loop because this binding (also for other tabs), which makes the c

[Differential] [Updated, 101 lines] D4739: make sure the cancel action is last

mart updated this revision to Diff 11682. mart added a comment. - adress comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4739?vs=11674&id=11682 BRANCH phab/cancelisLast REVISION DETAIL https://phabricator.kde.org/D4739 AFFECTED FILES src/widget

Re: Review Request 129917: Add a cache monitor to the System Load Viewer applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129917/ --- (Updated Feb. 23, 2017, 1:12 p.m.) Status -- This change has been ma

[Differential] [Closed] D4729: Fix disabling the spinner animation when Busy indicator has no opacity

This revision was automatically updated to reflect the committed changes. Closed by commit R242:13054c047311: Fix disabling the spinner animation when Busy indicator has no opacity (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phab

[Differential] [Closed] D4394: Fix potential crash in KCmFontInst on invalid index

This revision was automatically updated to reflect the committed changes. Closed by commit R119:755993315b6a: Fix potential crash in KCmFontInst on invalid index (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4394?vs=10821&

[Differential] [Request, 126 lines] D4740: Fonts KCM: Fix layout of hinting settings, port away from KDE4

marten created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change improves the layout of the font hinting sub-dialogue of this KCM. Previously there was no spacing around or between the GUI elemen

[Differential] [Updated] D4739: make sure the cancel action is last

dfaure added a comment. I like the encapsulation into a different class. INLINE COMMENTS > dropjob.cpp:63 > +public: > +DropMenu(QWidget *parent = 0); > +~DropMenu(); nullptr > dropjob.cpp:167 > + > +void DropMenu::addExtraActions(QList appActions, QList > pluginActions) > +{ unne

[Differential] [Commented On] D4736: Port: Expose port availability to QML

drosca added a comment. > What do I need to add in this file to make the comparision with "Port.Available" instead? You probably forgot import org.kde.plasma.private.volume. > We now know which ports of which sink are currently connected, right? When I take a look at my audio sink

[Maniphest] [Edited] T5412: Improve Plasma PA usability

subdiff edited the task description. TASK DETAIL https://phabricator.kde.org/T5412 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff Cc: broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts

[Differential] [Updated] D4739: make sure the cancel action is last

mart added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4739 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #frameworks, dfaure Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Request, 102 lines] D4739: make sure the cancel action is last

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY when adding extra actions to the drop menu, even if the menu was already shown, the cancel action should be the last anyways for us

[Differential] [Accepted] D4736: Port: Expose port availability to QML

subdiff accepted this revision. subdiff added a comment. This revision is now accepted and ready to land. Tested it and it works fine. Only problem was that I couldn't use "Port.Available", but probably only because I didn't define it somewhere in the QML file. What worked in DeviceListItem.q

[Differential] [Closed] D4732: [KCM] Rework design and structure

This revision was automatically updated to reflect the committed changes. Closed by commit R115:daeafed202f5: [KCM] Rework design and structure (authored by subdiff). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4732?vs=11650&id=11672 REV

[Differential] [Updated] D4732: [KCM] Rework design and structure

subdiff added a comment. > Then it will look out of place, all other KCMs use tabs. Also you can't use the tabbar from applet, as that is Plasma component (you can of course implement the same thing with QtQuickControls, but then again it will look out of place). There will be a redesig

[Differential] [Commented On] D4736: Port: Expose port availability to QML

drosca added inline comments. INLINE COMMENTS > subdiff wrote in port.cpp:39 > Better put the definition of this getter in the header. I prefer function definitions always in cpp file. > subdiff wrote in port.h:66 > Better put the definition of this long method in the cpp file. This is templat

[Differential] [Changed Subscribers] D4736: Port: Expose port availability to QML

subdiff added inline comments. INLINE COMMENTS > port.cpp:39 > +return m_availability; > } > Better put the definition of this getter in the header. > port.h:66 > } > } > Better put the definition of this long method in the cpp file. REPOSITORY R115 Plasma Audio Volum

[Differential] [Accepted] D4732: [KCM] Rework design and structure

drosca accepted this revision. drosca added a comment. This revision is now accepted and ready to land. > This Qt bug seems kinda weird. Not really, just another QtQuickControls1 bug ... > Maybe we should move away from using Tabs here? I thought about this, but haven't quite found t

[Differential] [Commented On] D4732: [KCM] Rework design and structure

subdiff added a comment. Thank you! This Qt bug seems kinda weird. Maybe we should move away from using Tabs here? I thought about this, but haven't quite found the way to go instead. Maybe the same nice looking buttons you use in the applet (with the blue line below)? Anyway, this woul

[Differential] [Commented On] D4736: Port: Expose port availability to QML

drosca added inline comments. INLINE COMMENTS > broulik wrote in port.h:37 > Not needed, perhaps even > > enum Availability { > Unknown = -1, > Unavailable, > Available > }; It matches the PA enum values (not that it is actually used though). REPOSITORY R115 Plasma Audi

[Differential] [Updated, 43 lines] D4736: Port: Expose port availability to QML

drosca updated this revision to Diff 11669. drosca added a comment. Don't set first enum value to 0 REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4736?vs=11667&id=11669 BRANCH master REVISION DETAIL https://phabricator.kde.org/D473

[Differential] [Accepted] D4729: Fix disabling the spinner animation when Busy indicator has no opacity

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D4729 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #p

[Differential] [Accepted] D4737: [Icon Applet] Reject unacceptable drags

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4737 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: plasma-devel, prog

[Differential] [Changed Subscribers] D4736: Port: Expose port availability to QML

broulik added inline comments. INLINE COMMENTS > port.h:37 > +enum Availability { > +Unknown = 0, > +Available, Not needed, perhaps even enum Availability { Unknown = -1, Unavailable, Available }; REPOSITORY R115 Plasma Audio Volume Applet REVISION

[Differential] [Request, 96 lines] D4737: [Icon Applet] Reject unacceptable drags

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN - Dragged a color from color picker onto any icon widget → it rejected it - Dragged a file onto an icon widget pointing to an image file → it reject

[Differential] [Request, 43 lines] D4736: Port: Expose port availability to QML

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Replaces old available property, which is not used anywhere and also was completely wrong. TEST PLAN Verified it is accessible from QML: p

FYI: Qt 5.9 has a "shared memory image provider"

Hi, This might be of interest for the IconItem and Frame stuf. I couldn't find this in the Qt 5.9 documentation, but it most certainly does exist [1] I wonder how many more "shared" options the QML Image{} component is going to add though. The current documentation already states: (5.8 docs) "Ima

[Maniphest] [Commented On] T5412: Improve Plasma PA usability

drosca added a comment. > Are there only few available description provided by PA? I.e. is it for video outputs always "HDMI / Displayport (...)"? In this case we could do some regex in order to replace the long strings by something shorter at least. You can see what properties are avail

Re: KMS backlight ABI proposition

On Wed, 22 Feb 2017, Hans de Goede wrote: > My first thought was that your proposal is reasonable, but on second > thought I foresee trouble here with e.g. the backlight level save / restore > code in systemd still using the sysfs interface, while the desktop > environment has moved on to the prop

[Differential] [Closed] D4677: Applet: Show info message when no devices found / applications playing audio

This revision was automatically updated to reflect the committed changes. Closed by commit R115:2322d0b4c669: Applet: Show info message when no devices found / applications playing audio (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabri

[Differential] [Updated] D4732: [KCM] Rework design and structure

drosca added a comment. I like it, looks much better! +1 Just a note, the tab titles were not elided because they were too long, but because of stupid Qt bug. You can try showing TabView with only one tab titled "Recording" and you'll see it is elided too, while much longer titles are no