subdiff accepted this revision. subdiff added a comment. This revision is now accepted and ready to land.
Tested it and it works fine. Only problem was that I couldn't use "Port.Available", but probably only because I didn't define it somewhere in the QML file. What worked in DeviceListItem.qml: `Ports[portbox.currentIndex].availability == 1` What do I need to add in this file to make the comparision with "Port.Available" instead? Some higher level questions regarding the overall goals: - We now know which ports of which sink are currently connected, right? When I take a look at my audio sink directly on the mainboard, it has one port at the back (lineout) and one at the front (headphones). I can switch between them in the KCM, which only changes the volume, but not the direction. I.e. when I have connected headphones I cannot change here to the port on the back, the sound will still come via the front port and the back port is marked as not available. When I manually disconnect the headphone, it switches to the back again. So is there a way to change this behaviour? - To know if a device is currently "connected", we would need to loop over all its port and check if atleast one of them is connected, right? But what about the "State" property of a sink? It seems to also indicate, if the device is currently used. Should we use this one instead? INLINE COMMENTS > drosca wrote in port.cpp:39 > I prefer function definitions always in cpp file. Ok > drosca wrote in port.h:66 > This is templated function, so that's why the definition is in header. There is a way around it, but probably doesn't make sense here. So ok. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D4736 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, subdiff Cc: subdiff, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
