Zren added inline comments. INLINE COMMENTS
> drosca wrote in ListItemBase.qml:283 > Please move literal to right side of comparison: `PulseObject.ports.length > > 0` or even in this case you can just write `PulseObject.ports.length`. > > But actually make it `Ports.length` as said in previous comment. Definitely go for the explicit `var > 0` as the latter could be read as "if this variable exists". That's usually used as a JS minimisation trick. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4751 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, drosca, Zren Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
