subdiff added inline comments.

INLINE COMMENTS
> port.cpp:39
> +    return m_availability;
>  }
>  

Better put the definition of this getter in the header.

> port.h:66
>          }
>      }
>  

Better put the definition of this long method in the cpp file.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D4736

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: subdiff, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Reply via email to