Re: Review Request 124495: Proofread ksysguard docbook for kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124495/ --- (Updated March 25, 2016, 10:07 p.m.) Status -- This change has been

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On March 25, 2016, 7:24 p.m., Thomas Pfeiffer wrote: > > Two questions: > > 1. If there is only one device, are the comoboxes hidden (they should be)? > > 2. If I change the default device, are all streams automatically switched > > to that device? > > David Rosca wrote: > 1. Yes > 2.

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On March 25, 2016, 10 a.m., David Rosca wrote: > > If pulse rejects the volume change when dragging the slider, the slider > > handle will jump from the cursor to the old value. > > Also, external volume changes (eg. with global shortcut) are now delayed by > > the timer. > > Anthony Fieroni

Review Request 127494: Fix drawing correct focus state of QtQuickControls Button

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127494/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze

[Differential] [Commented On] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

colomar added a comment. Makes sense! Sorry I don't know any shorter term for "mobile broadband". There are all sorts of acryonyms for individual mobile broadband technology, but since we don't know which one we're dealing with (or do we?), I fear we're stuck with that clunky term... REPO

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On March 25, 2016, 7:24 p.m., Thomas Pfeiffer wrote: > > Two questions: > > 1. If there is only one device, are the comoboxes hidden (they should be)? > > 2. If I change the default device, are all streams automatically switched > > to that device? > > David Rosca wrote: > 1. Yes > 2.

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On March 25, 2016, 7:24 p.m., Thomas Pfeiffer wrote: > > Two questions: > > 1. If there is only one device, are the comoboxes hidden (they should be)? > > 2. If I change the default device, are all streams automatically switched > > to that device? 1. Yes 2. No, it just sets the pulseaudio de

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On March 25, 2016, 5:28 p.m., Andreas Kainz wrote: > > would it be possible to use for the mute "button" an toolbar button or some > > button that doesn't look like a button. Yes, it can be changed to ToolButton. - David --- This is

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 25, 2016, 5:31 p.m., Andreas Kainz wrote: > > I'm not a big fan when you have one hidden feature to show an expand arrow. > > > > what's the difference between applications and devices? the grouping? in > > general I'm a big fan of a simple volumen widget where you can change the >

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/#review93996 --- Two questions: 1. If there is only one device, are the comobo

[Differential] [Commented On] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

broulik added a comment. F3: Screenshot_20160325_162127.png F4: Screenshot_20160325_16.png F5: Screenshot_20160325_162144.png REPOSITORY rPLASMAWORKSPACE P

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On Март 25, 2016, обяд, David Rosca wrote: > > If pulse rejects the volume change when dragging the slider, the slider > > handle will jump from the cursor to the old value. > > Also, external volume changes (eg. with global shortcut) are now delayed by > > the timer. > > Anthony Fieroni wro

[Differential] [Updated] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

broulik added a dependent revision: D1223: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1222 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefer

[Differential] [Request, 32 lines] D1223: [Touchpad KDED module] Show OSD when toggling touchpad with keyboard shortcut

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. broulik added a dependency: D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos. Her

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93994 --- I'm not a big fan when you have one hidden feature to show an

[Differential] [Request, 40 lines] D1222: RFC: Add WiFi, Mobile Broadband, Bluetooth, and Touchpad OSD infos

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design, jgrulich. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Whenever we turn something on o

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/#review93993 --- would it be possible to use for the mute "button" an toolbar

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/ --- (Updated March 25, 2016, 4:48 p.m.) Review request for Plasma and KDE Usa

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93991 --- Moving individual streams between devices is indeed probably

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On März 25, 2016, 4:15 nachm., Kai Uwe Broulik wrote: > > applet/contents/ui/ListItemBase.qml, lines 232-233 > > > > > > Is that thing still used given we don't have the ComboBox there > > anymore? Might allow

[Differential] [Updated] D1221: [Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog

broulik retitled this revision from "[Slideshow Wallpaper]" to "[Slideshow Wallpaper] Fix seconds always set to 1 when opening config dialog". broulik updated the summary for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1221 EMAIL

[Differential] [Closed] D1186: [Task Manager] Initiate drag only with left mouse button drag

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP57d7d66445ef: [Task Manager] Initiate drag only with left mouse button drag (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

Re: Review Request 127484: applet: Add streams tab to manage applications volume

> On March 25, 2016, 4:15 p.m., Kai Uwe Broulik wrote: > > applet/contents/ui/ListItemBase.qml, lines 232-233 > > > > > > Is that thing still used given we don't have the ComboBox there > > anymore? Might allow

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/#review93988 --- Fix it, then Ship it! If usability has no further comments

[Differential] [Updated] D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set

broulik added a dependent revision: D1221: [Slideshow Wallpaper]. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1220 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel

[Differential] [Updated] D1221: [Slideshow Wallpaper]

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1221 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel _

[Differential] [Request, 25 lines] D1221: [Slideshow Wallpaper]

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. broulik added a dependency: D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties a

[Differential] [Request, 76 lines] D1220: [Applet / Wallpaper Configuration] Load config page with initial cfg properties already set

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Rather than creating the config page and then setting the pro

Re: Considering a Qt 5.6 dependency for plasma-workspace

On Thursday, March 24, 2016 5:31:21 PM CET Aleix Pol wrote: > Hi, > I'd like to suggest a Qt 5.6 dependency for plasma-workspace master > (and maybe other repositories too). > > My personal interest is mostly because of the patch that drops KScreen > dependency in plasmashell [1], but I still thin

Re: Review Request 127484: applet: Add streams tab to manage applications volume

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127484/ --- (Updated March 25, 2016, 2:38 p.m.) Review request for Plasma and KDE Usa

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On März 25, 2016, 1:55 nachm., Kai Uwe Broulik wrote: > > src/kcm/package/contents/ui/SinkInputView.qml, line 53 > > > > > > ? > > David Rosca wrote: > Not my comment, copied from applet/contents/ui/SourceO

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

> On March 25, 2016, 1:43 p.m., Kai Uwe Broulik wrote: > > src/client.cpp, lines 62-65 > > > > > > Isn't KService::serviceByStorageId sufficient? > > > > The docs say "This function will try very hard to

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On March 25, 2016, 1:55 p.m., Kai Uwe Broulik wrote: > > src/kcm/package/contents/ui/SinkInputView.qml, line 53 > > > > > > ? Not my comment, copied from applet/contents/ui/SourceOutputListItem.qml Also I thin

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On März 25, 2016, 1:41 nachm., Kai Uwe Broulik wrote: > > While I like seeing this option return, especially with your other "Primary > > Device" patch makes this UI really cluttered. > > > > What about having a drop down button with the device icon rather than the > > full-blown text in the

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/#review93981 --- src/kcm/package/contents/ui/SinkInputView.qml (line 53)

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

> On March 25, 2016, 1:41 p.m., Kai Uwe Broulik wrote: > > While I like seeing this option return, especially with your other "Primary > > Device" patch makes this UI really cluttered. > > > > What about having a drop down button with the device icon rather than the > > full-blown text in ther

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127467/#review93978 --- src/client.cpp (lines 62 - 65)

Re: Review Request 127492: KCM: Add possibility to move stream to other devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/#review93977 --- While I like seeing this option return, especially with your

Re: Review Request 127467: PulseClient: Implement heuristics to find icon for stream

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127467/ --- (Updated March 25, 2016, 1:39 p.m.) Review request for Plasma. Changes

Review Request 127492: KCM: Add possibility to move stream to other devices

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/ --- Review request for Plasma and KDE Usability. Repository: plasma-pa Desc

[Breeze] [Bug 360967] New: The breeze-plymouth theme contains subdirectories

https://bugs.kde.org/show_bug.cgi?id=360967 Bug ID: 360967 Summary: The breeze-plymouth theme contains subdirectories Product: Breeze Version: 5.6.0 Platform: Other OS: Linux Status: UNCONFIRMED Severity:

[Differential] [Accepted] D1113: New Desktop Theme KCM

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Good stuff, David! :) INLINE COMMENTS kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml:31 Please add a note in the code for that, then REPOSITORY rPLASMADESKTOP Plasma Desktop

[Differential] [Accepted] D1185: drkonqi mappings: Move baloo_file* to "frameworks-baloo|Baloo File Daemon"

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH Plasma/5.6 REVISION DETAIL https://phabricator.kde.org/D1185 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/ema

[Differential] [Accepted] D1186: [Task Manager] Initiate drag only with left mouse button drag

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1186 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broul

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On March 25, 2016, 10 a.m., David Rosca wrote: > > If pulse rejects the volume change when dragging the slider, the slider > > handle will jump from the cursor to the old value. > > Also, external volume changes (eg. with global shortcut) are now delayed by > > the timer. > > Anthony Fieroni

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

> On Март 25, 2016, обяд, David Rosca wrote: > > If pulse rejects the volume change when dragging the slider, the slider > > handle will jump from the cursor to the old value. > > Also, external volume changes (eg. with global shortcut) are now delayed by > > the timer. 1. About me, rejected v

Re: Review Request 127476: [Volume item] Increase / decrease by wheel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93967 --- If pulse rejects the volume change when dragging the slider,