----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/#review93981 -----------------------------------------------------------
src/kcm/package/contents/ui/SinkInputView.qml (line 53) <https://git.reviewboard.kde.org/r/127492/#comment64007> ? src/kcm/package/contents/ui/SinkInputView.qml (line 57) <https://git.reviewboard.kde.org/r/127492/#comment64006> Is this needed given you set it above? or does ComboBox in its infinite wisdom try to find it on its own as soon as you change the model? src/kcm/package/contents/ui/SourceOutputView.qml (lines 29 - 30) <https://git.reviewboard.kde.org/r/127492/#comment64008> Is there a way you can make this a component used by both items? probably needs a property string role: "Source" so it can tell between whether to use Source or Sink and then you could do currentIndex = mapToIndex(model[role + "Index"]) and rest looks identical to me? src/kcm/package/contents/ui/StreamListItem.qml (line 63) <https://git.reviewboard.kde.org/r/127492/#comment64009> I don't think this label is needed src/kcm/package/contents/ui/StreamListItem.qml (lines 70 - 71) <https://git.reviewboard.kde.org/r/127492/#comment64010> I'd rather do: sourceComponent: deviceComboBox // with that always being a valid component active: model.sources.length > 1 Makes it more obvious imho, I wouldn't expect the sourceComponent to change elsewhere - Kai Uwe Broulik On März 25, 2016, 1:34 nachm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127492/ > ----------------------------------------------------------- > > (Updated März 25, 2016, 1:34 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-pa > > > Description > ------- > > Add combobox next to mute button with available devices. > > > Diffs > ----- > > src/kcm/package/contents/ui/SinkInputView.qml PRE-CREATION > src/kcm/package/contents/ui/SourceOutputView.qml PRE-CREATION > src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e > src/kcm/package/contents/ui/StreamView.qml b08c87a > src/kcm/package/contents/ui/main.qml 3360201 > > Diff: https://git.reviewboard.kde.org/r/127492/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot_20160325_142736.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/25/06b2aafd-f05d-4140-933a-89fbc8ed7c5c__Screenshot_20160325_142736.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
