> On March 25, 2016, 10 a.m., David Rosca wrote: > > If pulse rejects the volume change when dragging the slider, the slider > > handle will jump from the cursor to the old value. > > Also, external volume changes (eg. with global shortcut) are now delayed by > > the timer. > > Anthony Fieroni wrote: > 1. About me, rejected value is a corner case and behavior can not be > expected. > 2. Why?! ValueChanged is not emitted on global shortcut? I will check > that. > > David Rosca wrote: > 1. It worked before > 2. Because valueChanged is emitted only when the slider value is changed > by user. External volume changes go through PulseObject.volume changes > (=onVolumeChanged). > > Anthony Fieroni wrote: > Shortcuts works. I test: > 1. Media keys - works > 2. Assign other key conbination - wotks
It works, but is delayed by the timer (200ms) which isn't that big issue, just a change (it was instant before). The issue with dragging and rejected volume change should be fixed though. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127476/#review93967 ----------------------------------------------------------- On March 24, 2016, 6:25 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127476/ > ----------------------------------------------------------- > > (Updated March 24, 2016, 6:25 p.m.) > > > Review request for Plasma, David Rosca and Harald Sitter. > > > Repository: plasma-pa > > > Description > ------- > > I don't know why it's disabled, it's pretty handy > > > Diffs > ----- > > applet/contents/ui/ListItemBase.qml 2e31eeb > src/kcm/package/contents/ui/VolumeSlider.qml 7904a5d > > Diff: https://git.reviewboard.kde.org/r/127476/diff/ > > > Testing > ------- > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
