> On März 25, 2016, 1:55 nachm., Kai Uwe Broulik wrote: > > src/kcm/package/contents/ui/SinkInputView.qml, line 53 > > <https://git.reviewboard.kde.org/r/127492/diff/1/?file=454008#file454008line53> > > > > ? > > David Rosca wrote: > Not my comment, copied from applet/contents/ui/SourceOutputListItem.qml > > Also I think we don't probably need this combobox in applet (to keep it > simple), now that it will be available from KCM.
Yeah, let's not complicate the applet for an option that theoretically nobody should need if PulseAudio wasn't dumb. If the option's in the KCM only that's just fine. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127492/#review93981 ----------------------------------------------------------- On März 25, 2016, 1:34 nachm., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127492/ > ----------------------------------------------------------- > > (Updated März 25, 2016, 1:34 nachm.) > > > Review request for Plasma and KDE Usability. > > > Repository: plasma-pa > > > Description > ------- > > Add combobox next to mute button with available devices. > > > Diffs > ----- > > src/kcm/package/contents/ui/SinkInputView.qml PRE-CREATION > src/kcm/package/contents/ui/SourceOutputView.qml PRE-CREATION > src/kcm/package/contents/ui/StreamListItem.qml 7f1d69e > src/kcm/package/contents/ui/StreamView.qml b08c87a > src/kcm/package/contents/ui/main.qml 3360201 > > Diff: https://git.reviewboard.kde.org/r/127492/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > Screenshot_20160325_142736.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/25/06b2aafd-f05d-4140-933a-89fbc8ed7c5c__Screenshot_20160325_142736.png > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
