Re: [Development] How to speed up QML for KDE5 without QML compiler

2015-09-16 Thread Leslie Zhai
在 2015年09月16日 17:51, Konstantin Tokarev 写道: 16.09.2015, 07:04, "Leslie Zhai" : Hi great Qt and KDE developers, I like QML, it is high speed development language, easy to create candy UI and not difficult to debug. KDE4 began to use it in some projects, for example, KScreen`s kcm module, it us

Review Request 125277: Update recentApplicationCount in all places we modify applications list

2015-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125277/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 125240: Use lineedit svg margins in sizeHint calculation

2015-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125240/ --- (Updated Sept. 16, 2015, 11:02 p.m.) Status -- This change has been

Re: Review Request 125265: kcm_keyboard: Fix crash when trying to show invalid preview

2015-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125265/#review85523 --- Ship it! >I couldn't reproduce this crash, but according to t

Re: Review Request 125264: kcm_keyboard: Fix showing shortcuts

2015-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125264/#review85522 --- Ship it! Ship It! - David Edmundson On Sept. 16, 2015, 6:0

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 16, 2015, 9:49 п.п.) Review request for Plasma and Solid.

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
> On Сен. 16, 2015, 6:57 п.п., Valerio De Angelis wrote: > > File Attachment: Applet with error message - snapshot11.png > > > > > > Could be possible to put the applications list in bold? That would be better, right. But simply adding

Re: oxygen-icons & plasma-workspace-wallpapers moved to git

2015-09-16 Thread Sebastian Kügler
On Wednesday, September 16, 2015 11:52:02 Jonathan Riddell wrote: > I think the default wallpaper should be kept alongside plasma-workspace, > less chance of not having it installed by accident +1. We need at least one default wallpaper working, the rest is optional. -- sebas Sebastian Kügler

Review Request 125266: Authentication with certificates / Make MRU/MTU editable / Dialog fix

2015-09-16 Thread René Fürst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125266/ --- Review request for Plasma. Repository: plasma-nm Description --- A

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
> On Сен. 16, 2015, 6:57 п.п., Valerio De Angelis wrote: > > File Attachment: Applet with error message - snapshot11.png > > > > > > Could be possible put here: > > 1) the same application list shown in the device page as per the >

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Valerio De Angelis
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review85507 --- File Attachment: Applet with error message - snapshot11.png <

Re: Review Request 125256: kded_keyboard: Fix restoring application/window specific layout settings

2015-09-16 Thread David Rosca
> On Sept. 16, 2015, 1:11 p.m., David Edmundson wrote: > > +1 > > > > given it's a behavioural change and I don't use keyboard layout switching > > (there is only one true layout!) I'd like someone else to comment on the > > session restoring. I can see arguments for both restoring and always

Review Request 125265: kcm_keyboard: Fix crash when trying to show invalid preview

2015-09-16 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125265/ --- Review request for Plasma. Bugs: 348694 https://bugs.kde.org/show_bug

Re: Review Request 125226: move EventForge from the desktop containment

2015-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 6:19 p.m.) Review request for KDE Frameworks, Pl

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

2015-09-16 Thread Igor Poboiko
https://bugs.kde.org/show_bug.cgi?id=352442 --- Comment #10 from Igor Poboiko --- (In reply to Kevin Funk from comment #9) > @Igor: Do you have a link to the upstream issue? Is there a bug report at > all? I didn't report anything myself, and not sure if there is relevant bug report there. Alt

Review Request 125264: kcm_keyboard: Fix showing shortcuts

2015-09-16 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125264/ --- Review request for Plasma. Bugs: 350756 https://bugs.kde.org/show_bug

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 16, 2015, 6:07 п.п.) Review request for Plasma and Solid.

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-16 Thread Marco Martin
> On Sept. 16, 2015, 4:22 p.m., andreas kainz wrote: > > Hi I add some applet icons in 256x256px in kde:breeeze > > (https://quickgit.kde.org/?p=breeze.git&a=commit&h=f75b729531a75df1536b7340fcb016a5752ebf69) > > I need feedback how it looks and if it would work for you snapshot8 that's how the

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125135/ --- (Updated Sept. 16, 2015, 5:59 p.m.) Review request for Plasma and andreas

Re: Review Request 125226: move EventForge from the desktop containment

2015-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 5:40 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125226: move EventForge from the desktop containment

2015-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 4:44 p.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-16 Thread andreas kainz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125135/#review85500 --- Hi I add some applet icons in 256x256px in kde:breeeze (https

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

2015-09-16 Thread Kevin Funk
https://bugs.kde.org/show_bug.cgi?id=352442 --- Comment #9 from Kevin Funk --- @Igor: Do you have a link to the upstream issue? Is there a bug report at all? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel ma

Re: Review Request 125256: kded_keyboard: Fix restoring application/window specific layout settings

2015-09-16 Thread David Rosca
> On Sept. 16, 2015, 1:11 p.m., David Edmundson wrote: > > +1 > > > > given it's a behavioural change and I don't use keyboard layout switching > > (there is only one true layout!) I'd like someone else to comment on the > > session restoring. I can see arguments for both restoring and always

Re: Review Request 125256: kded_keyboard: Fix restoring application/window specific layout settings

2015-09-16 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125256/#review85495 --- +1 given it's a behavioural change and I don't use keyboard l

Re: oxygen-icons & plasma-workspace-wallpapers moved to git

2015-09-16 Thread Jonathan Riddell
I think the default wallpaper should be kept alongside plasma-workspace, less chance of not having it installed by accident Jonathan On Wed, Sep 16, 2015 at 01:32:32PM +0200, kainz.a wrote: > Thanks Harald, > > about the wallpapers. The standard Wallpaper is in kde:breeze should we move > the

Re: oxygen-icons & plasma-workspace-wallpapers moved to git

2015-09-16 Thread Harald Sitter
On Wed, Sep 16, 2015 at 1:32 PM, kainz.a wrote: > about the wallpapers. The standard Wallpaper is in kde:breeze should we move > them into plasma-workspace-wallpapers? the question is that the > plasma-workspace-wallpapers are an additional package and the standard > wallpaper change at each Plasm

Re: oxygen-icons & plasma-workspace-wallpapers moved to git

2015-09-16 Thread kainz.a
Thanks Harald, about the wallpapers. The standard Wallpaper is in kde:breeze should we move them into plasma-workspace-wallpapers? the question is that the plasma-workspace-wallpapers are an additional package and the standard wallpaper change at each Plasma release so the git size in kde:breeze i

oxygen-icons & plasma-workspace-wallpapers moved to git

2015-09-16 Thread Harald Sitter
As requested by the VDG all artworky bits moved out of svn and into git because git is awesome and all that... # oxygen-icons moved from kdesupport svn to git. Newly available at kde:oxygen-icons. Also going to be in plasma release scope for 5.5 as the VDG wants to continue maintaining the theme.

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 16, 2015, 10:59 д.п.) Review request for Plasma and Solid.

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
> On Сен. 16, 2015, 10:11 д.п., Kai Uwe Broulik wrote: > > I really like that! > > > > The device notifier UI itself is questionable with the popup telling us > > "the device xyz failed to unmount" rather than just highlighting the device > > and showing the message in the list directly but th

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Kai Uwe Broulik
> On Sept. 16, 2015, 10:11 vorm., Kai Uwe Broulik wrote: > > I really like that! > > > > The device notifier UI itself is questionable with the popup telling us > > "the device xyz failed to unmount" rather than just highlighting the device > > and showing the message in the list directly but

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/#review85488 --- I really like that! The device notifier UI itself is question

Review Request 125256: kded_keyboard: Fix restoring application/window specific layout settings

2015-09-16 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125256/ --- Review request for Plasma. Bugs: 325572 https://bugs.kde.org/show_bug

Re: Review Request 125226: move EventForge from the desktop containment

2015-09-16 Thread Marco Martin
> On Sept. 15, 2015, 9:41 p.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp, line 259 > > > > > > This adds the same item multiple times. > > > > If you have an

Re: Review Request 125226: move EventForge from the desktop containment

2015-09-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/ --- (Updated Sept. 16, 2015, 9:12 a.m.) Review request for KDE Frameworks, Pl

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
> On Сен. 15, 2015, 10:41 п.п., Martin Klapetek wrote: > > dataengines/devicenotifications/ksolidnotify.cpp, line 122 > > > > > > This should be a private method rather than a static method > > > > (and

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125248/ --- (Updated Сен. 16, 2015, 7:23 д.п.) Review request for Plasma and Solid.

Re: Review Request 125248: Display name of process which blocks umount / eject

2015-09-16 Thread Igor Poboiko
> On Сен. 16, 2015, 12:21 д.п., Xuetian Weng wrote: > > dataengines/devicenotifications/ksolidnotify.cpp, line 131 > > > > > > I'd prefer to make it async. Are you talking about whole getBlockingApps function or