----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125265/#review85523 -----------------------------------------------------------
Ship it! >I couldn't reproduce this crash, but according to the backtrace this should >fix it. A lot of fixes are like that. It's a good skill to have though, good work! - David Edmundson On Sept. 16, 2015, 6:24 p.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125265/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 6:24 p.m.) > > > Review request for Plasma. > > > Bugs: 348694 > https://bugs.kde.org/show_bug.cgi?id=348694 > > > Repository: plasma-desktop > > > Description > ------- > > Rules::getLayoutInfo() can return null. > > > Diffs > ----- > > kcms/keyboard/kcm_keyboard_widget.cpp fb49eb6 > > Diff: https://git.reviewboard.kde.org/r/125265/diff/ > > > Testing > ------- > > I couldn't reproduce this crash, but according to the backtrace this should > fix it. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel