----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125256/#review85495 -----------------------------------------------------------
+1 given it's a behavioural change and I don't use keyboard layout switching (there is only one true layout!) I'd like someone else to comment on the session restoring. I can see arguments for both restoring and always starting from the same layout each time. - David Edmundson On Sept. 16, 2015, 9:41 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125256/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 9:41 a.m.) > > > Review request for Plasma. > > > Bugs: 325572 > https://bugs.kde.org/show_bug.cgi?id=325572 > > > Repository: plasma-desktop > > > Description > ------- > > This removes the check if user has restore session on start option enabled, > so the layout map is restored everytime. > > It also checks in LayoutMemory::laoutChanged if the changed keyboard layout > is different from user configured to prevent clearing the layout map on > startup. > > > Diffs > ----- > > kcms/keyboard/layout_memory.cpp 5ac6729 > kcms/keyboard/layout_memory_persister.cpp da48739 > > Diff: https://git.reviewboard.kde.org/r/125256/diff/ > > > Testing > ------- > > Per-application (or per-window) layouts are now preserved. > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
