> On Sept. 15, 2015, 9:41 p.m., David Edmundson wrote: > > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp, line 259 > > <https://git.reviewboard.kde.org/r/125226/diff/3/?file=403436#file403436line259> > > > > This adds the same item multiple times. > > > > If you have an item with a child: the first itteration will add it and > > the child, then we recurse and add the child again. > > > > I think you can kill the > > > > itemList.append(parentItem->childItems()) > > > > ?
is probably itemList.append(parentItem); that should be removed, as "allChildItems" suggests the child items but not the parent itself - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125226/#review85466 ----------------------------------------------------------- On Sept. 16, 2015, 9:12 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125226/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2015, 9:12 a.m.) > > > Review request for KDE Frameworks, Plasma and Eike Hein. > > > Repository: kdeclarative > > > Description > ------- > > EventForge can cancel the half-managed events of child items > in order to implement the move of them with press and hold, > not having the parent and the children battling for the same > press-move-release event sequence. > > API-wise I think it's fine, apart perhaps the EventForge class name > (perhaps MouseEventGrabber is less technically correct, but still more clear?) > > > Diffs > ----- > > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.h a62efb7 > src/qmlcontrols/kquickcontrolsaddons/mouseeventlistener.cpp d3321a3 > > Diff: https://git.reviewboard.kde.org/r/125226/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
