Re: Review Request 123671: add visibleWhileDesktopShown property

> On May 7, 2015, 11:23 a.m., Marco Martin wrote: > > I think i would like more either all panels always shown or always hidden. > > however I'm fine, given the discussion on this if this mechanism is used > > instead. > > just a question: wouldn't make more sense to use this in a private > > c

Behaviour of "Show Desktop"

Hi, With 5.3.0, we have introduced a new behaviour for the "show desktop" button and shortcuts. The effect is now more dashboard like, applications are visually not hidden anymore but stashed aside, and the panel is invisible. The problem is that we have missed quite a few corner cases and igno

Re: Where to place kcron in systemsettings5?

On Friday 08 of May 2015 01:34:14 Christoph Feck wrote: > On Friday 08 May 2015 01:10:18 David Edmundson wrote: > > ​Probably just not ported? > > Only the category needs to be ported, but I am unsure where it > belongs. If I understand Burkhard's comment correctly, there is no > longer an "Admini

Re: Where to place kcron in systemsettings5?

On Friday 08 May 2015 01:10:18 David Edmundson wrote: > ​Probably just not ported? Only the category needs to be ported, but I am unsure where it belongs. If I understand Burkhard's comment correctly, there is no longer an "Administration" category in systemsettings.

Re: Where to place kcron in systemsettings5?

​Probably just not ported? David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Where to place kcron in systemsettings5?

Hi, bug 347028 says kcron is not visible in systemsettings, because of the recategorization. Besides finding a new home, I wonder why it isn't displayed. Wasn't there some "lost+found" type of category in KDE4's systemsettings? Christoph Feck (kdepepo) _

Good news regarding Qt 5.5

Hi guys, As you might know, I tried to get Plasma some time ago working on Qt 5.5 and failed miserably. [1] As you'll have guessed by the subject, that's not the case anymore, since the last patch by Simon [2]. This means Qt 5.5 is a firm candidate for Plasma 5.4. Also let me use this occasion to

Re: Review Request 123671: add visibleWhileDesktopShown property

> On Mai 7, 2015, 11:23 vorm., Marco Martin wrote: > > I think i would like more either all panels always shown or always hidden. > > however I'm fine, given the discussion on this if this mechanism is used > > instead. > > just a question: wouldn't make more sense to use this in a private > >

Re: Review Request 123493: Fix leaky incubation controller

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/ --- (Updated May 7, 2015, 9:20 p.m.) Status -- This change has been mark

Re: Review Request 123492: Fix memory leak in AppletQuickItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123492/ --- (Updated May 7, 2015, 9:18 p.m.) Status -- This change has been mark

Re: Review Request 123633: remove support for dbusmenuqt <4.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123633/ --- (Updated May 7, 2015, 9:17 p.m.) Status -- This change has been mark

Re: Review Request 123671: add visibleWhileDesktopShown property

> On May 7, 2015, 11:23 a.m., Marco Martin wrote: > > I think i would like more either all panels always shown or always hidden. > > however I'm fine, given the discussion on this if this mechanism is used > > instead. > > just a question: wouldn't make more sense to use this in a private > > c

Re: Review Request 123671: add visibleWhileDesktopShown property

> On Mai 7, 2015, 11:23 vorm., Marco Martin wrote: > > I think i would like more either all panels always shown or always hidden. > > however I'm fine, given the discussion on this if this mechanism is used > > instead. > > just a question: wouldn't make more sense to use this in a private > >

Re: Review Request 123673: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123673/#review80050 --- Ship it! good to me src/plasmaquick/configmodel.cpp (line 2

Re: Review Request 123671: add visibleWhileDesktopShown property

> On Mai 7, 2015, 11:23 vorm., Marco Martin wrote: > > I think i would like more either all panels always shown or always hidden. > > however I'm fine, given the discussion on this if this mechanism is used > > instead. > > just a question: wouldn't make more sense to use this in a private > >

Re: Review Request 123674: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123674/ --- (Updated May 7, 2015, 2:45 p.m.) Review request for Plasma. Repository:

Re: Review Request 123673: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123673/ --- (Updated May 7, 2015, 2:38 p.m.) Review request for Plasma. Repository:

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 7, 2015, 2:31 p.m.) Status -- This change has been mark

Re: Review Request 123674: capability to load QML kcms in plasmoid config windows

> On May 7, 2015, 1:02 p.m., David Edmundson wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 51 > > > > > > there's a behavioural change if > > > > model.source == "" >

Re: Review Request 123673: capability to load QML kcms in plasmoid config windows

> On May 7, 2015, 12:59 p.m., Sebastian Kügler wrote: > > I think it would be good to use QStringList for the kcm role, I don't see > > why we should limit this functionality to just one KCM, especially since > > the key in the metadata is also a list. > > Marco Martin wrote: > yes, is pos

Re: Review Request 123673: capability to load QML kcms in plasmoid config windows

> On May 7, 2015, 1:07 p.m., David Edmundson wrote: > > src/plasmaquick/configmodel.cpp, line 213 > > > > > > who owns the KCM? > > > > this model or the QMLEngine requesting the KCM? > > > > if

Re: Review Request 123674: capability to load QML kcms in plasmoid config windows

> On May 7, 2015, 1:02 p.m., David Edmundson wrote: > > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml, line 51 > > > > > > there's a behavioural change if > > > > model.source == "" >

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 7, 2015, 1:15 p.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123674: capability to load QML kcms in plasmoid config windows

> On May 7, 2015, 1:02 p.m., David Edmundson wrote: > > desktoppackage/contents/configuration/AppletConfiguration.qml, line 223 > > > > > > I don't get this line, even when we have a kcm, we still have a > > sou

Re: Review Request 123673: capability to load QML kcms in plasmoid config windows

> On May 7, 2015, 12:59 p.m., Sebastian Kügler wrote: > > I think it would be good to use QStringList for the kcm role, I don't see > > why we should limit this functionality to just one KCM, especially since > > the key in the metadata is also a list. yes, is possible to load more than one kc

Re: Review Request 123673: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123673/#review80041 --- src/plasmaquick/configmodel.cpp (line 213)

Re: Review Request 123674: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123674/#review80039 --- Ship it! Pending adjustments in https://git.reviewboard.kde.o

Re: Review Request 123674: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123674/#review80038 --- Ship it! Cool stuff desktoppackage/contents/configuration/A

Re: Review Request 123673: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123673/#review80037 --- I think it would be good to use QStringList for the kcm role,

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 7, 2015, 11:59 a.m., Sebastian Kügler wrote: > > src/declarativeimports/plasmacomponents/qml/private/TabBarLayout.qml, line > > 197 > > > > > > This line may have slipped in? ouch, i pushed a commit in

Review Request 123674: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123674/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 123673: capability to load QML kcms in plasmoid config windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123673/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 123671: add visibleWhileDesktopShown property

> On Mai 7, 2015, 11:23 vorm., Marco Martin wrote: > > I think i would like more either all panels always shown or always hidden. > > however I'm fine, given the discussion on this if this mechanism is used > > instead. > > just a question: wouldn't make more sense to use this in a private > >

Re: Review Request 123671: add visibleWhileDesktopShown property

> On May 7, 2015, 11:23 a.m., Marco Martin wrote: > > I think i would like more either all panels always shown or always hidden. > > however I'm fine, given the discussion on this if this mechanism is used > > instead. > > just a question: wouldn't make more sense to use this in a private > > c

Re: Reverting review 123473

On Thu, May 7, 2015 at 1:03 AM, David Edmundson wrote: > We had an agreement that there would be no regressions when porting any KCMs > to QML. > > The following regressions remain in the newly ported KCM: > > - combo boxes load in wrong places > https://codereview.qt-project.org/#/c/111326/ isn'

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review80030 --- Ship it! Looks good. src/declarativeimports/plasmacomponent

Re: Review Request 123671: add visibleWhileDesktopShown property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123671/#review80028 --- I think i would like more either all panels always shown or al

Review Request 123671: add visibleWhileDesktopShown property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123671/ --- Review request for Plasma and Marco Martin. Bugs: 346837, 346933 and 3472

[plasmashell] [Bug 346425] crash when you want to change the time of image sequences

https://bugs.kde.org/show_bug.cgi?id=346425 Christoph Feck changed: What|Removed |Added Target Milestone|--- |1.0 Component|general

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/#review80025 --- solved issues, still there the magic self() call, for that, an

Re: Review Request 123626: port libplasma away from sycoca as much as possible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123626/ --- (Updated May 7, 2015, 9:06 a.m.) Review request for KDE Frameworks and Pl

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote: > > src/plasma/pluginloader.cpp, line 892 > > > > > > Can this lead to containmentactions being listed twice? (I haven't seen > > it in the UI, but seems pla

Re: Reverting review 123473

On Thursday 07 May 2015, David Edmundson wrote: > We had an agreement that there would be no regressions when porting any > KCMs to QML. > > The following regressions remain in the newly ported KCM: > > - combo boxes load in wrong places > https://codereview.qt-project.org/#/c/111326/ isn't merg

Re: Review Request 123626: port libplasma away from sycoca as much as possible

> On May 6, 2015, 10:54 p.m., Sebastian Kügler wrote: > > src/plasma/pluginloader.cpp, line 826 > > > > > > Why? This remark makes it kinda magical and doesn't provide any other > > information than "rather don'