----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123671/#review80028 -----------------------------------------------------------
I think i would like more either all panels always shown or always hidden. however I'm fine, given the discussion on this if this mechanism is used instead. just a question: wouldn't make more sense to use this in a private component of the show desktop applet instead of giving api for everything? I feel the use case so far is quite limited to a potential single applet. If then more applets come out that would need this, it could be moved in bindings (of which i would prefer in appletinterface rather than appletquickitem) src/plasmaquick/appletquickitem.h (line 94) <https://git.reviewboard.kde.org/r/123671/#comment54912> I would prefer it in AppletInterface, as appletquickitem is mostly for qml loading and exports public symbols - Marco Martin On May 7, 2015, 11:14 a.m., Thomas Lübking wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123671/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 11:14 a.m.) > > > Review request for Plasma and Marco Martin. > > > Bugs: 346837, 346933 and 347212 > http://bugs.kde.org/show_bug.cgi?id=346837 > http://bugs.kde.org/show_bug.cgi?id=346933 > http://bugs.kde.org/show_bug.cgi?id=347212 > > > Repository: plasma-framework > > > Description > ------- > > plasmoids only need to add > Plasmoid.visibleWhileDesktopShown: true; > to ensure their panel (and thus them) remains visible while showing the > desktop > > This is achieved by setting the panel transient for the (first found, under > them and visible) desktop type window. > > This is mostly relevant for the showdesktop plasmoid (for now) > > Notice that all bugs are only CC, we need this to be used in the showdesktop > plasmoid. > > > Diffs > ----- > > src/plasmaquick/appletquickitem.h dffbcf3 > src/plasmaquick/appletquickitem.cpp 0748a8d > src/plasmaquick/private/appletquickitem_p.h a1ec683 > > Diff: https://git.reviewboard.kde.org/r/123671/diff/ > > > Testing > ------- > > added/removed (multiple) showdesktop plasmoids - panel transient for correct > desktop window (and visible) unless the last is gone (they seem to be deleted > with a short random delay?) > > > Thanks, > > Thomas Lübking > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
