> On May 7, 2015, 1:02 p.m., David Edmundson wrote: > > desktoppackage/contents/configuration/AppletConfiguration.qml, line 223 > > <https://git.reviewboard.kde.org/r/123674/diff/1/?file=367378#file367378line223> > > > > I don't get this line, even when we have a kcm, we still have a > > sourcefile set to ConfigurationKcmPage ?
not at the moment, since the model is created by the part in libplasma it doesn't know about it so is empty. I can hardcode that name tough - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123674/#review80038 ----------------------------------------------------------- On May 7, 2015, 12:41 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123674/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 12:41 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > this is the plasma shell package part of the kcm load of plasmoid config > dialogs. > > > Diffs > ----- > > desktoppackage/contents/configuration/AppletConfiguration.qml 4daccdd > desktoppackage/contents/configuration/ConfigCategoryDelegate.qml 301ea29 > desktoppackage/contents/configuration/ConfigurationKcmPage.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123674/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
