----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123673/#review80050 -----------------------------------------------------------
Ship it! good to me src/plasmaquick/configmodel.cpp (line 211) <https://git.reviewboard.kde.org/r/123673/#comment54925> cache d->categories.at(index.row())->pluginName() it will make this a lot more readable as it's used in 4 places. - David Edmundson On May 7, 2015, 2:38 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123673/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 2:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > With the same mechanism as plasma 1, add the possibility to load kcms > directly in the plasmoids config windows. this works only for qml based ones. > the apply enable and trigger is correctly wired between the config dialog and > kcm apis. > > example: > http://wstaw.org/m/2015/05/07/plasma-desktopvZ1594.png > > > Diffs > ----- > > src/plasma/data/servicetypes/plasma-applet.desktop 476c819 > src/plasmaquick/configmodel.h f1b4441 > src/plasmaquick/configmodel.cpp ca10f84 > src/plasmaquick/configview.cpp 32c5f6e > > Diff: https://git.reviewboard.kde.org/r/123673/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
