Re: Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Martin Gräßlin
> On April 23, 2015, 1:32 p.m., Aleix Pol Gonzalez wrote: > > daemon/backends/upower/powerdevilupowerbackend.cpp, line 161 > > > > > > Is it fine to use exec() here? no, I missed that one :-( - Martin --

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79413 --- Apart from more technical issues, the patch includes changes t

[Powerdevil] [Bug 346456] When screen turn off automatically, it will turn black twice.

2015-04-23 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=346456 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de --- Comment #1 from Ka

Re: Review Request 123478: ensure the filePath "metadata" is there

2015-04-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/#review79394 --- Ship it! Yes, please. I was wondering if I could rely on met

Re: Review Request 123478: ensure the filePath "metadata" is there

2015-04-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/ --- (Updated April 23, 2015, 2:41 p.m.) Status -- This change has been m

Review Request 123478: ensure the filePath "metadata" is there

2015-04-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123478/ --- Review request for KDE Frameworks, Plasma and Sebastian Kügler. Repositor

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tou

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 23, 2015, 2:20 p.m.) Status -- This change has been m

Re: Review Request 122660: Breeze Decoration Redesign

2015-04-23 Thread Hugo Pereira Da Costa
> On Feb. 21, 2015, 1:44 p.m., Hugo Pereira Da Costa wrote: > > "Preinstalled colours schemes to ensure consistent colouring" > > that is a regression with respect to exiting code. Its a no go. Please > > include. > > > > "Updated the behaviour of the resize grip - fixed bug for fullscreen" >

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Bhushan Shah
> On April 23, 2015, 7:42 p.m., Bhushan Shah wrote: > > Ship It! > > Ashish Madeti wrote: > What about the .cache discussion? debate on some other day? :P More I think about it we don't want to use .cache. Reasons 1) This is for only playing media files and not all files in medialibrary 2)

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Ashish Madeti
> On April 23, 2015, 7:42 p.m., Bhushan Shah wrote: > > Ship It! What about the .cache discussion? debate on some other day? :P - Ashish --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/1

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79387 --- Ship it! Ship It! - Bhushan Shah On April 23, 2015, 7:25 p

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79386 --- Looks good from my POV, I'll let the maintainer chech "ship it

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/ --- (Updated April 23, 2015, 2:08 p.m.) Review request for Plasma. Reposito

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Ashish Madeti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/ --- (Updated April 23, 2015, 7:25 p.m.) Review request for Plasma, Bhushan Sh

Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces

2015-04-23 Thread Sebastian Kügler
> On April 22, 2015, 10:35 p.m., Sebastian Kügler wrote: > > libs/mediacenter/mpris2/mpris2.cpp, line 33 > > > > > > Actually, this is wrong now. Using the native separator may produce \ > > (on Windows, for exam

Plasma 5.3.0 tars

2015-04-23 Thread Jonathan Riddell
Tars are up now on depot for packagers, release due on Tuesday https://www.kde.org/announcements/plasma-5.3.0.php https://www.kde.org/info/plasma-5.3.0.php Let me know of any problems Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://

Build failed in Jenkins: plasma-workspace_stable_qt5 #116

2015-04-23 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER L

Build failed in Jenkins: plasma-desktop_stable_qt5 #126

2015-04-23 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LIN

Build failed in Jenkins: kinfocenter_stable_qt5 #18

2015-04-23 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUIL

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Eike Hein
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? > > Marco Martin wrote: > none. > not too much pain as well tou

Re: Review Request 122660: Breeze Decoration Redesign

2015-04-23 Thread Aleix Pol Gonzalez
> On Feb. 21, 2015, 2:44 p.m., Hugo Pereira Da Costa wrote: > > "Preinstalled colours schemes to ensure consistent colouring" > > that is a regression with respect to exiting code. Its a no go. Please > > include. > > > > "Updated the behaviour of the resize grip - fixed bug for fullscreen" >

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79374 --- > This is more an experiment on how much modules can be closel

Re: Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/#review79375 --- daemon/backends/upower/powerdevilupowerbackend.cpp (line 156)

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin
> On April 23, 2015, 11:31 a.m., Eike Hein wrote: > > > This is more an experiment on how much modules can be closely ported (and > > > in how much time). > > > > What's the benefit to the user of merging this version now? none. not too much pain as well tough. all of them have to eventually b

Review Request 123475: Execute KAuth jobs for brightness control in an async manner

2015-04-23 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123475/ --- Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerde

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/ --- (Updated April 23, 2015, 11 a.m.) Review request for Plasma. Repository

Jenkins build is back to stable : plasma-workspace_master_qt5 #1482

2015-04-23 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Lasse Liehu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79373 --- Messages.sh needs to be adjusted for translations in .qml file

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread David Edmundson
> On April 23, 2015, 9:56 a.m., David Edmundson wrote: > > kcms/cursortheme/package/contents/ui/Delegate.qml, line 32 > > > > > > This isn't a suitable long term substitute for the QStyle highlights. > > > >

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79369 --- kcms/cursortheme/kcmcursortheme.cpp (lines 589 - 590)

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin
On April 23, 2015, 9:56 a.m., Marco Martin wrote: > > I have a cmake issue since you moved some stuff. > > > > -- The following OPTIONAL packages have not been found: > > * USB , User level access to USB devices , > >Provides Logitech mouse support in KContro

Re: Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin
> On April 23, 2015, 9:56 a.m., David Edmundson wrote: > > kcms/cursortheme/package/contents/ui/Delegate.qml, line 32 > > > > > > This isn't a suitable long term substitute for the QStyle highlights. > > > >

Build failed in Jenkins: plasma-desktop_stable_qt5 #125

2015-04-23 Thread KDE CI System
See Changes: [kde] Migrate kickoff favourites -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in worksp

Build failed in Jenkins: plasma-desktop_stable_qt5 #124

2015-04-23 Thread KDE CI System
See Changes: [jr] Update version number for 5.3.0 -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in wo

Re: Review Request 123469: Migrate kickoff favourites

2015-04-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123469/ --- (Updated April 23, 2015, 9:47 a.m.) Status -- This change has been m

Build failed in Jenkins: kinfocenter_stable_qt5 #17

2015-04-23 Thread KDE CI System
See Changes: [jr] Update version number for 5.3.0 -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in worksp

Jenkins build is back to normal : kde-gtk-config_stable_qt5 #16

2015-04-23 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: polkit-kde-agent-1_stable_qt5 #6

2015-04-23 Thread KDE CI System
See Changes: [jr] Update version number for 5.3.0 -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in

Build failed in Jenkins: plasma-workspace_stable_qt5 #115

2015-04-23 Thread KDE CI System
See Changes: [jr] Update version number for 5.3.0 -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in

Build failed in Jenkins: sddm-kcm_stable_qt5 #10

2015-04-23 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (.desktop file) [jr] Update version number for 5.2.90 [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messa

Build failed in Jenkins: kmenuedit_stable_qt5 #8

2015-04-23 Thread KDE CI System
See Changes: [jr] Update version number for 5.2.90 [kde] Remove separator functionality [hein] Bump minimum Qt version to 5.4.0. [montel] Use new kde_ macro [montel] rename icons [montel] Use StartupNotify [lueck] screenshot update

Build failed in Jenkins: khotkeys_stable_qt5 #15

2015-04-23 Thread KDE CI System
See Changes: [jr] Update version number for 5.2.90 [scripty] SVN_SILENT made messages (.desktop file) [scripty] SVN_SILENT made messages (.desktop file) [jr] use ecm_optional_add_subdirectory instead of add_subdirectory for docs, the t

Review Request 123473: Port mouse theme kcm to QML

2015-04-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/ --- Review request for Plasma. Repository: plasma-desktop Description -