> On April 23, 2015, 9:56 a.m., David Edmundson wrote: > > kcms/cursortheme/package/contents/ui/Delegate.qml, line 32 > > <https://git.reviewboard.kde.org/r/123473/diff/1/?file=362590#file362590line32> > > > > This isn't a suitable long term substitute for the QStyle highlights. > > > > run Oxygen and it will look wrong.
what would you propose for this? we would need to either make a new element that paints with qstyle or getting that in qtcontrols (which i guess are a frozen since are being replaced?) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79369 ----------------------------------------------------------- On April 23, 2015, 8:39 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123473/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 8:39 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This is more an experiment on how much modules can be closely ported (and in > how much time). > the mouse theme kcm should be pretty much feature complete. > the main problem is the size combobox missing the cursor image due to the > QtQuickControls ComboBox being very limited and without a customizable > delegate. > all the other functions such as add/remove/ghns seems to work well > > > Diffs > ----- > > kcms/cursortheme/CMakeLists.txt 13ed816 > kcms/cursortheme/cursortheme.desktop f443208 > kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION > kcms/cursortheme/kcmcursortheme.h d9e32b2 > kcms/cursortheme/kcmcursortheme.cpp 44576ff > kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION > kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION > kcms/cursortheme/package/metadata.desktop PRE-CREATION > kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 > kcms/cursortheme/xcursor/itemdelegate.cpp e737005 > kcms/cursortheme/xcursor/previewwidget.h 4a11e2d > kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 > kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 > kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 > kcms/cursortheme/xcursor/thememodel.h bcf046a > kcms/cursortheme/xcursor/thememodel.cpp 4e4647f > kcms/cursortheme/xcursor/themepage.h 98c69fd > kcms/cursortheme/xcursor/themepage.cpp 687bd65 > kcms/cursortheme/xcursor/themepage.ui 6efe60b > > Diff: https://git.reviewboard.kde.org/r/123473/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > cursorskcm.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
