> On April 23, 2015, 7:42 p.m., Bhushan Shah wrote: > > Ship It! > > Ashish Madeti wrote: > What about the .cache discussion? debate on some other day? :P
More I think about it we don't want to use .cache. Reasons 1) This is for only playing media files and not all files in medialibrary 2) We are already using KImageCache to store album covers. so that would result in duplication. So temp directory is fine. - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123467/#review79387 ----------------------------------------------------------- On April 23, 2015, 7:25 p.m., Ashish Madeti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123467/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 7:25 p.m.) > > > Review request for Plasma, Bhushan Shah, Sebastian Kügler, Shantanu Tushar, > and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > ------- > > Save Cover art to a temporary folder. Include the path of the cover art in > the metadata currently exposed with MPRIS interfaces. > > > Diffs > ----- > > libs/mediacenter/mpris2/mpris2.cpp f03d062 > > Diff: https://git.reviewboard.kde.org/r/123467/diff/ > > > Testing > ------- > > Correct path is showing up in the metadata when tested with mpristester. > Correct cover art is showing up in the mpris controller (appearing in system > tray) of Plasma 5. > > > Thanks, > > Ashish Madeti > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
