----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123473/#review79369 -----------------------------------------------------------
kcms/cursortheme/kcmcursortheme.cpp (lines 589 - 590) <https://git.reviewboard.kde.org/r/123473/#comment54225> Not a review comment, but I love this line if you don't press continue, continue. kcms/cursortheme/package/contents/ui/Delegate.qml (line 32) <https://git.reviewboard.kde.org/r/123473/#comment54227> This isn't a suitable long term substitute for the QStyle highlights. run Oxygen and it will look wrong. kcms/cursortheme/package/contents/ui/Delegate.qml (line 59) <https://git.reviewboard.kde.org/r/123473/#comment54228> there's an attached isCurrentItem for delegates. kcms/cursortheme/package/contents/ui/main.qml (line 41) <https://git.reviewboard.kde.org/r/123473/#comment54226> you can make this the top level item. kcms/cursortheme/package/contents/ui/main.qml (line 66) <https://git.reviewboard.kde.org/r/123473/#comment54229> I'm possibly missing something but we don't set the initial index on load. I have a cmake issue since you moved some stuff. -- The following OPTIONAL packages have not been found: * USB , User level access to USB devices , <http://libusb.sourceforge.net> Provides Logitech mouse support in KControl. CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: LIBUSB_INCLUDE_DIR (ADVANCED) used as include directory in directory /home/david/projects/kde5/src/kde/workspace/plasma-desktop/kcms/cursortheme - David Edmundson On April 23, 2015, 8:39 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123473/ > ----------------------------------------------------------- > > (Updated April 23, 2015, 8:39 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > This is more an experiment on how much modules can be closely ported (and in > how much time). > the mouse theme kcm should be pretty much feature complete. > the main problem is the size combobox missing the cursor image due to the > QtQuickControls ComboBox being very limited and without a customizable > delegate. > all the other functions such as add/remove/ghns seems to work well > > > Diffs > ----- > > kcms/cursortheme/CMakeLists.txt 13ed816 > kcms/cursortheme/cursortheme.desktop f443208 > kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION > kcms/cursortheme/kcmcursortheme.h d9e32b2 > kcms/cursortheme/kcmcursortheme.cpp 44576ff > kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION > kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION > kcms/cursortheme/package/metadata.desktop PRE-CREATION > kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9 > kcms/cursortheme/xcursor/itemdelegate.cpp e737005 > kcms/cursortheme/xcursor/previewwidget.h 4a11e2d > kcms/cursortheme/xcursor/previewwidget.cpp 79d1305 > kcms/cursortheme/xcursor/sortproxymodel.h 95c9646 > kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309 > kcms/cursortheme/xcursor/thememodel.h bcf046a > kcms/cursortheme/xcursor/thememodel.cpp 4e4647f > kcms/cursortheme/xcursor/themepage.h 98c69fd > kcms/cursortheme/xcursor/themepage.cpp 687bd65 > kcms/cursortheme/xcursor/themepage.ui 6efe60b > > Diff: https://git.reviewboard.kde.org/r/123473/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > cursorskcm.png > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
