Re: Review Request 122842: Allow selecting notifications position on screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/#review78385 --- Thank you for adding usability! If the checkbox is disabled,

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 4:44 p.m., Marco Martin wrote: > > An undo feature can be done as following: > > the wallpaper model would have a role like "pendingDeletion" that would be > > set by the remove button on the thumbnail. At that point the thumbnail can > > show an undo button based on the rol

Jenkins build is back to normal : plasma-desktop_master_qt5 #1145

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-desktop_master_qt5 #1143

See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 4:44 p.m., Marco Martin wrote: > > An undo feature can be done as following: > > the wallpaper model would have a role like "pendingDeletion" that would be > > set by the remove button on the thumbnail. At that point the thumbnail can > > show an undo button based on the rol

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 4:44 nachm., Marco Martin wrote: > > An undo feature can be done as following: > > the wallpaper model would have a role like "pendingDeletion" that would be > > set by the remove button on the thumbnail. At that point the thumbnail can > > show an undo button based on the r

Build failed in Jenkins: plasma-desktop_master_qt5 #1142

See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 3:58 nachm., Kai Uwe Broulik wrote: > > I don't think the wallpaper dialog should ever delete an actual image file, > > especially not when it's in the user's Pictures folder. Only exception is > > when it has been installed through GHNS in which case it is in some hidden >

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 4:44 p.m., Marco Martin wrote: > > An undo feature can be done as following: > > the wallpaper model would have a role like "pendingDeletion" that would be > > set by the remove button on the thumbnail. At that point the thumbnail can > > show an undo button based on the rol

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 4:44 nachm., Marco Martin wrote: > > An undo feature can be done as following: > > the wallpaper model would have a role like "pendingDeletion" that would be > > set by the remove button on the thumbnail. At that point the thumbnail can > > show an undo button based on the r

Re: Review Request 122842: Allow selecting notifications position on screen

> On April 1, 2015, 4:48 p.m., Kai Uwe Broulik wrote: > > applets/notifications/plugin/notificationshelper.h, line 35 > > > > > > If you already have WRITE and NOTIFY, just add a READ too MEMBER creates an implic

Re: Review Request 122842: Allow selecting notifications position on screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/#review78362 --- Ship it! In principle I would prefer setting the position by

Re: Review Request 122842: Allow selecting notifications position on screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/#review78360 --- Ship it! Some really minor nit picky things below, feel free

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78359 --- An undo feature can be done as following: the wallpaper model

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 3:58 p.m., Kai Uwe Broulik wrote: > > I don't think the wallpaper dialog should ever delete an actual image file, > > especially not when it's in the user's Pictures folder. Only exception is > > when it has been installed through GHNS in which case it is in some hidden > >

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 3:58 nachm., Kai Uwe Broulik wrote: > > I don't think the wallpaper dialog should ever delete an actual image file, > > especially not when it's in the user's Pictures folder. Only exception is > > when it has been installed through GHNS in which case it is in some hidden >

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 4:13 nachm., Thomas Pfeiffer wrote: > > I agree with Kai: Asking for confirmation in this case is not the approach > > we should take. > > What this definitely calls for is an undo function, which should certainly > > not be impossible to do. > > > > Asking for confirmation

Re: Review Request 123213: Add an option to enable/disable the blue focus highlight on frames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123213/#review78355 --- Hi David, What's the rationale behind this option ? How do yo

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78354 --- I agree with Kai: Asking for confirmation in this case is not

Review Request 123213: Add an option to enable/disable the blue focus highlight on frames

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123213/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: oxygen

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

> On April 1, 2015, 3:58 p.m., Kai Uwe Broulik wrote: > > I don't think the wallpaper dialog should ever delete an actual image file, > > especially not when it's in the user's Pictures folder. Only exception is > > when it has been installed through GHNS in which case it is in some hidden > >

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78350 --- I don't think the wallpaper dialog should ever delete an actua

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78347 --- The complex part of the wallpapers is in some cases it actuall

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78348 --- wallpapers/image/imagepackage/contents/ui/config.qml (line 25

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78346 --- wallpapers/image/imagepackage/contents/ui/config.qml (line 25

Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- Review request for Plasma. Bugs: 338729 https://bugs.kde.org/show_bug

Re: Review Request 122884: Use the new KDecoration API for getting additional colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122884/ --- (Updated April 1, 2015, 3:25 p.m.) Status -- This change has been ma

Re: Review Request 122842: Allow selecting notifications position on screen

> On April 1, 2015, 4:45 p.m., Martin Klapetek wrote: > > Hello? C++ code looks good to me, QML needs to be reviewed by someone else - Martin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.or

Re: Review Request 122842: Allow selecting notifications position on screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/#review78341 --- Hello? - Martin Klapetek On March 24, 2015, 1:19 p.m., Mart

Re: Review Request 122884: Use the new KDecoration API for getting additional colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122884/#review78340 --- Can someone commit this for me since I don't have commit acces

Re: Review Request 122884: Use the new KDecoration API for getting additional colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122884/ --- (Updated huhti 1, 2015, 5:39 ip) Review request for kwin and Plasma. Su

Re: Review Request 123210: Don't display black square if icon is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123210/ --- (Updated April 1, 2015, 2:06 p.m.) Status -- This change has been ma

Re: Review Request 123210: Don't display black square if icon is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123210/#review78338 --- Ship it! src/qmlcontrols/kquickcontrolsaddons/qiconitem.cpp

Review Request 123210: Don't display black square if icon is not set

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123210/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Build failed in Jenkins: plasma-desktop_master_qt5 #1141

See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Release Dates for August

On Wed, Apr 1, 2015 at 2:52 PM, David Edmundson wrote: > Vishesh, what's your plan for baloo-widgets? > I still don't have a concrete plan. Possible options - 1. Release it with the applications release since dolphin uses it 2. Merge the code with dolphin since it is the only user. I'm leaning

Re: Release Dates for August

On Mon, Mar 30, 2015 at 5:32 PM, Jonathan Riddell wrote: > Plasma 5.4 release schedule needs writing and keeping to our 3 months > would release in July. That puts the release during Akademy so it > needs shifting. > > Baloo wants to move from Plasma to Frameworks. At the same time it > will ge

Re: Release Dates for August

On Mon, Mar 30, 2015 at 5:32 PM, Jonathan Riddell wrote: > Plasma 5.4 release schedule needs writing and keeping to our 3 months > would release in July. That puts the release during Akademy so it > needs shifting. > > Works for me, it makes it possible for me to deploy my high DPI stuff if appl

Re: Release Dates for August

An obvious +1 from my side. On Mon, Mar 30, 2015 at 5:32 PM, Jonathan Riddell wrote: > Plasma 5.4 release schedule needs writing and keeping to our 3 months > would release in July. That puts the release during Akademy so it > needs shifting. > > Baloo wants to move from Plasma to Frameworks.

Re: Proposal regarding plasmate's release

Any news on this? besides plasmate, the repository has other utilities (plasmoidviewer, plasmaengineexplorer, plasmathemeexplorer, cuttlefish) that really NEED to be released On Thursday 29 January 2015, Giorgos Tsiapaliokas wrote: > Hello, > > I believe that before we release plasmate we shoul

Build failed in Jenkins: plasma-workspace_master_qt5 #1433

See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in workspace

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

> On April 1, 2015, 10:54 a.m., Hugo Pereira Da Costa wrote: > > (from the branch, not from the patch). > > All is good. > > Thanks ! > > > > (PS: will you push a similar thing for oxygen ?) Yes, I planned to push into oxygen too - David

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123188/ --- (Updated April 1, 2015, 10:57 a.m.) Status -- This change has been m

Re: Review Request 123188: Replicate functionality of Frameworks KStyle for KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123188/#review78321 --- Ship it! (from the branch, not from the patch). All is good.

bluezqt admin

congratulations on getting bluezqt moved to kde/workspace :) Could you set me as KDE Project Manager in projects.kde.org? I need to be able to make branches and tag for releases. What's the next step? Merging the qbluez branch of bluedevil? (else it'll need libbluedevil frameworks branch merg