> On April 1, 2015, 10:54 a.m., Hugo Pereira Da Costa wrote: > > (from the branch, not from the patch). > > All is good. > > Thanks ! > > > > (PS: will you push a similar thing for oxygen ?)
Yes, I planned to push into oxygen too - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123188/#review78321 ----------------------------------------------------------- On April 1, 2015, 10:57 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123188/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 10:57 a.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: breeze > > > Description > ------- > > Some important style hints are supplied by the KStyle class, mostly > importantly whether listviews activate folders on single or double > click. > > For frameworks this now exists in KStyle, so code was not included in > Breeze and latest Oxygen. However for KDE4 builds we still need this > code. > > There is a KDE4 kstyle class, but this behvaiour is very different and > causes conflicts and a lot of other problems. Re-implementing the part > we need seems the easier approach > > > Diffs > ----- > > kstyle/CMakeLists.txt e13a13d > kstyle/animations/breezegenericdata.cpp aa7c154 > kstyle/breezestyle.h f9df1e8 > kstyle/kstylekde4compat.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123188/diff/ > > > Testing > ------- > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
