----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78347 -----------------------------------------------------------
The complex part of the wallpapers is in some cases it actually removes the file, sometimes it doesn't depending on whether we got it from GHNS or the user just selected a file. Do we want the dialog every time when it's a local file and no deleting actually occurs? I'm not sure either way. I certainly think we should avoid saying "delete" in the message when we're not deleting the file. wallpapers/image/imagepackage/contents/ui/config.qml (line 251) <https://git.reviewboard.kde.org/r/123211/#comment53635> QQC label on top of a plamsa frame is very liable to be lead to a black text on black background situation. No Plamsa.Anything should ever be used in config dialogs. Maybe http://doc.qt.io/qt-5/qml-qtquick-dialogs-messagedialog.html is better? - David Edmundson On April 1, 2015, 3:27 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123211/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 3:27 p.m.) > > > Review request for Plasma. > > > Bugs: 338729 > https://bugs.kde.org/show_bug.cgi?id=338729 > > > Repository: plasma-workspace > > > Description > ------- > > This patch is adding a confirmation dialog which is being called before we > remove a wallpaper. > > > Diffs > ----- > > wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f > wallpapers/image/imagepackage/contents/ui/config.qml 2108082 > > Diff: https://git.reviewboard.kde.org/r/123211/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > dialog > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
