----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78359 -----------------------------------------------------------
An undo feature can be done as following: the wallpaper model would have a role like "pendingDeletion" that would be set by the remove button on the thumbnail. At that point the thumbnail can show an undo button based on the role. Upon apply or ok, a "commitDeletion" method would be called on the model instance. this would go trough all the items and do the removeWallpaper on the ones that have the PendingDeletion role set. Cancel would not delete anything. Antonis, would you feel giving a try on it? - Marco Martin On April 1, 2015, 3:27 p.m., Antonis Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123211/ > ----------------------------------------------------------- > > (Updated April 1, 2015, 3:27 p.m.) > > > Review request for Plasma. > > > Bugs: 338729 > https://bugs.kde.org/show_bug.cgi?id=338729 > > > Repository: plasma-workspace > > > Description > ------- > > This patch is adding a confirmation dialog which is being called before we > remove a wallpaper. > > > Diffs > ----- > > wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f > wallpapers/image/imagepackage/contents/ui/config.qml 2108082 > > Diff: https://git.reviewboard.kde.org/r/123211/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > dialog > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png > > > Thanks, > > Antonis Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
