Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review64951 --- I did not do a proper review for the QML part - there are more

Re: Re: Wayland protocols

On Wednesday 20 August 2014 21:10:58 Eike Hein wrote: > Hi, > > to start another subtopic: Do we have startup notifications > on our radar? > > http://standards.freedesktop.org/startup-notification-spec/startup-notificat > ion-latest.txt > http://www.freedesktop.org/wiki/Software/startup-notifica

Re: Review Request 119874: Make Kicker's root item a FocusScope

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119874/#review64947 --- Ship it! Ship It! - Eike Hein On Aug. 20, 2014, 9:27 p.m.,

Re: Review Request 119874: Make Kicker's root item a FocusScope

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119874/ --- (Updated Aug. 20, 2014, 9:27 p.m.) Review request for Plasma and Eike Hei

Review Request 119874: Make Kicker's root item a FocusScope

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119874/ --- Review request for Plasma and Eike Hein. Repository: plasma-desktop Des

Re: Review Request 119870: Make TabGroup a focus scope

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119870/#review64932 --- Ship it! Ship It! - Marco Martin On Aug. 20, 2014, 7:20 p.

Re: Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119872/#review64931 --- Ship it! Ship It! - Marco Martin On Aug. 20, 2014, 7:23 p.

Review Request 119872: AppletInterface::init should set focus not forceActiveFocus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119872/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 119870: Make TabGroup a focus scope

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119870/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 118180: slideshow BUG patch fix

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118180/ --- (Updated Aug. 20, 2014, 7:13 p.m.) Status -- This change has been ma

Re: Wayland protocols

Hi, to start another subtopic: Do we have startup notifications on our radar? http://standards.freedesktop.org/startup-notification-spec/startup-notification-latest.txt http://www.freedesktop.org/wiki/Software/startup-notification/ KDE has an implementation of this that is used by libtaskmanag

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 6:51 p.m.) Status -- This change has been ma

Re: Review Request 119860: hints to disable background in dialogs

> On Aug. 20, 2014, 4:56 p.m., Sebastian Kügler wrote: > > src/plasmaquick/dialog.h, line 124 > > > > > > Since the background hint is mutually exclusive (semantically, and in > > the code), wouldn't BackgroundH

Re: Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/#review64924 --- File Attachment: Klipper with thumbnails - klipper-thumbnails

Review Request 119866: Thumbnails in Klipper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119866/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64922 --- Ship it! Ship It! - David Edmundson On Aug. 20, 2014, 1:05

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 66 > > > > > > If we don't have a config even though we correctly configured the > > backend, should not we fail? a Q

Re: Review Request 119860: hints to disable background in dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/#review64918 --- src/plasmaquick/dialog.h

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 1:55 p.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 66 > > > > > > If we don't have a config even though we correctly configured the > > backend, should not we fail? a QS

Review Request 119860: hints to disable background in dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119860/ --- Review request for Plasma and Pier Luigi Fiorini. Repository: plasma-fram

Re: Review Request 119822: QScreen backend for libkscreen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119822/ --- (Updated Aug. 20, 2014, 4:35 p.m.) Review request for Plasma and Solid.

Re: Review Request 119822: QScreen backend for libkscreen

> On Aug. 18, 2014, 11:55 a.m., Àlex Fiestas wrote: > > autotests/testqscreenbackend.cpp, line 90 > > > > > > Q_FOREACH > > Martin Gräßlin wrote: > or instead of using Qt macros one could use what the languag

Re: Re: Wayland protocols

On Wednesday 20 August 2014 16:41:23 Ivan Čukić wrote: > > Personally I don't understand why kamd needs to know the internal Id of a > > window. Is this really needed or could it solved differently (e.g. using > > additional interface/requests which kwin then forwards to kamd)? If not > > it's abou

Re: Wayland protocols

> Personally I don't understand why kamd needs to know the internal Id of a > window. Is this really needed or could it solved differently (e.g. using > additional interface/requests which kwin then forwards to kamd)? If not it's > about time that we express the need for a global id in the xdg_she

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 1:05 p.m.) Review request for KDE Frameworks and

Re: Kioslave repos

On Wednesday 20 of August 2014 11:38:12 Jonathan Riddell wrote: > On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: > >On Tue, Aug 19, 2014 at 9:49 PM, David Faure wrote: > > On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: > > > On Tue, Jul 01, 2014 at 11:25:11PM +0

Re: Kioslave repos

On Wed, Aug 20, 2014 at 12:28:30PM +0200, Aleix Pol wrote: >On Tue, Aug 19, 2014 at 9:49 PM, David Faure wrote: > > On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: > > On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote: > > > On Sunday 27 April 2014 19:35:37 I

Re: Kioslave repos

On Tue, Aug 19, 2014 at 9:49 PM, David Faure wrote: > On Tuesday 01 July 2014 22:25:15 Jonathan Riddell wrote: > > On Tue, Jul 01, 2014 at 11:25:11PM +0200, David Faure wrote: > > > On Sunday 27 April 2014 19:35:37 I wrote: > > > > > * place that repo in kde/ or kde/ in the > projects.kde.org > >

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

> On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line > > 51 > > > > > > checked isn't a boolean, it's an enum of the checked, partia

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/ --- (Updated Aug. 20, 2014, 9:36 a.m.) Review request for KDE Frameworks and

Re: Re: Wayland protocols

On Wednesday 20 August 2014 10:26:22 Marco Martin wrote: > On Wednesday 20 August 2014, Ivan Čukić wrote: > > So, either the window needs to know its id, or it needs to be able to > > resolve the id through kwin and kwin passes the info to kamd, or > > something. > > so, in a nutter-shell, QWindow

Re: Wayland protocols

> so, in a nutter-shell, :) > QWindow::winId to be the same as the id that KWin > would store internally i guess Yes, that would be perfect. -- Cheerio, Ivan KDE, ivan.cukic at kde.org, http://ivan.fomentgroup.org/ gpg key id: 850B6F76, keyserver.pgp.com __

Re: Review Request 119846: qtcontrols port for checkbox and radiobutton

> On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line > > 33 > > > > > > Good question. > > > > I think it is needed to set

Re: Kioslave repos

On Tuesday 19 August 2014, David Faure wrote: > > > Does anyone disagree with my line of thought above? > > > > plasma-devel list may also have an opinion on this, sending there. > > Any news? To me it should be in whatever place it is better for most people, and if there are use cases for it b

Re: Wayland protocols

On Wednesday 20 August 2014, Ivan Čukić wrote: > So, either the window needs to know its id, or it needs to be able to > resolve the id through kwin and kwin passes the info to kamd, or > something. so, in a nutter-shell, QWindow::winId to be the same as the id that KWin would store internally i