----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119872/#review64931 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On Aug. 20, 2014, 7:23 p.m., Frederik Gladhorn wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119872/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 7:23 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Setting the focus is a good thing, the problem with forceActiveFocus is > that it will not allow any child to receive the actual focus, instead > the focus is forced on to the root element of the applet which may not > be desired. > When for example trying to improve keyboard focus behavior of KickOff > without this patch I cannot get the initial focus on the list of > favorites since it gets reset after the applet is created. > > > Diffs > ----- > > src/scriptengines/qml/plasmoid/appletinterface.cpp fd92f46 > > Diff: https://git.reviewboard.kde.org/r/119872/diff/ > > > Testing > ------- > > Made accessibility focus handling work in KickOff. Patches for KickOff still > need cleanup. > > > Thanks, > > Frederik Gladhorn > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel