> On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line > > 51 > > <https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line51> > > > > checked isn't a boolean, it's an enum of the checked, partial, > > unchecked. > > Marco Martin wrote: > eew, the tristate stuff, right..
checked is a boolean, and still used in radio, the tristate thing is checkedState and is used now in checkbox - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64882 ----------------------------------------------------------- On Aug. 20, 2014, 9:36 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119846/ > ----------------------------------------------------------- > > (Updated Aug. 20, 2014, 9:36 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this ports checkbox and radiobuttons (and switch that at least on desktop > formfactor is just an alias for checkboxes) to qtcontrols and adds the > corresponding styles > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/CheckBox.qml 5e98d11 > src/declarativeimports/plasmacomponents/qml/RadioButton.qml 00a1bbf > src/declarativeimports/plasmacomponents/qml/Switch.qml d0608f9 > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml > PRE-CREATION > src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml > PRE-CREATION > src/desktoptheme/breeze/widgets/actionbutton.svgz 25aacc8 > > Diff: https://git.reviewboard.kde.org/r/119846/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
