> On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line > > 33 > > <https://git.reviewboard.kde.org/r/119846/diff/1/?file=306474#file306474line33> > > > > Good question. > > > > I think it is needed to set background to something otherwise it will > > use the one in the Base style.
i *think* it's used to emulate autoFillBackground of QWidgets, so we don't want that, and an empty Item should be fine > On Aug. 19, 2014, 7:43 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml, > > line 44 > > <https://git.reviewboard.kde.org/r/119846/diff/1/?file=306475#file306475line44> > > > > Can/should this be fixed inside the SVGs? > > > > Otherwise we're doing breeze hacks at a code level, a themer who > > creates both as rectangles will get one inexplicably larger i could adjust the theme, yeah. may look bit buggy on old themes tough - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119846/#review64882 ----------------------------------------------------------- On Aug. 19, 2014, 5:21 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119846/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2014, 5:21 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > this ports checkbox and radiobuttons (and switch that at least on desktop > formfactor is just an alias for checkboxes) to qtcontrols and adds the > corresponding styles > > > Diffs > ----- > > src/declarativeimports/plasmacomponents/qml/CheckBox.qml 5e98d11 > src/declarativeimports/plasmacomponents/qml/RadioButton.qml 00a1bbf > src/declarativeimports/plasmacomponents/qml/Switch.qml d0608f9 > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml > PRE-CREATION > src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119846/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
