Review Request 118824: Fix for "Bug 336414 - Playlist switching doesnt move highlight"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118824/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 336414

Build failed in Jenkins: plasma-desktop_master_qt5 #333

See Changes: [sebas] Replace KMessageBox with KMessageWidget for missing language warnings -- [...truncated 740 lines...] Generating moc_leavemodel.cpp Generating moc_processrunner.cpp Genera

Build failed in Jenkins: plasma-desktop_master_qt5 #332

See Changes: [sebas] Spacing in kickoff's config page [sebas] Fix translations in kickoff's config page -- [...truncated 739 lines...] Generating kcmtranslations.moc Generating moc_kcmtransl

Build failed in Jenkins: plasma-workspace_master_qt5 #477

See Changes: [sebas] Don't abuse smallSpacing -- [...truncated 1220 lines...] Generating moc_statusnotifieritemjob.cpp Generating moc_statusnotifieritemservice.cpp Generating moc_statusnoti

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

> On June 18, 2014, 3:33 p.m., Marco Martin wrote: > > would have preferred something private just for the battery, > > org.kde.plasma.workspace.components makes too easy to make it a dumpster... > > > > aaanyways, that's fine iff adding or modifying anything in > > org.kde.plasma.workspace.co

Build failed in Jenkins: plasma-desktop_master_qt5 #331

See Changes: [hein] Restore the original icon and label positioning approach. -- [...truncated 748 lines...] Scanning dependencies of target kcm_fonts_automoc [ 19%] Scanning dependencies of

Build failed in Jenkins: plasma-desktop_master_qt5 #330

See Changes: [hein] Fix loading schema-less paths in the non-tilde-expansion case. -- [...truncated 757 lines...]

Build failed in Jenkins: plasma-desktop_master_qt5 #329

See Changes: [hein] Fix logic error. [hein] Fix place-relative label generation for custom paths. [hein] Cleanup. [hein] Don't screw with user-entered value. -- [...truncated 769 lines...]

Re: Review Request 118636: Reinstate login & logout sounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118636/#review60439 --- in the end this causes massive issues on startup - kdeinit blo

Build failed in Jenkins: plasma-workspace_master_qt5 #476

See Changes: [hrvoje.senjan] Use correct sound theme, KDE got renamed to Oxygen theme -- [...truncated 1200 lines...] [ 18%] [ 18%] Built target plasma_engine_share_automoc Scanning depende

Re: Launcher tab icons

On Wednesday 18 June 2014 10:54:07 Andrew Lake wrote: > Marco, > > Per the discussion on the VDG forum, here are the launcher icons. For the > "Leave" tab, there's already a logout icon, so rather than create another > one, I suggest using that instead of the shutdown icon since it seems like > a

Launcher tab icons

Marco, Per the discussion on the VDG forum, here are the launcher icons. For the "Leave" tab, there's already a logout icon, so rather than create another one, I suggest using that instead of the shutdown icon since it seems like a better metaphorical representation of "Leave". Oh, and I'm not at

Build failed in Jenkins: plasma-workspace_master_qt5 #475

See Changes: [notmart] use "complementary" colors -- [...truncated 1206 lines...] Scanning dependencies of target kded_solidautoeject_automoc Scanning dependencies of target drkonqi_automoc

Build failed in Jenkins: plasma-workspace_master_qt5 #474

See Changes: [notmart] initialize -- [...truncated 1207 lines...] Generating moc_shareprovider.cpp Generating moc_shareservice.cpp [ 18%] [ 18%] [ 18%] Generating phononbackend.json Built t

Re: Review Request 118804: Register ksmserver as logind session leader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118804/#review60423 --- ksmserver/screenlocker/logind.cpp

Build failed in Jenkins: plasma-workspace_master_qt5 #473

See Changes: [aleixpol] No need to write config and re-position everything upon resize event [aleixpol] Explicitly call panelview::show -- [...truncated 1233 lines...] [ 18%] Generating ba

Re: Review Request 118799: Move BatteryIcon to org.kde.plasma.extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118799/#review60422 --- would have preferred something private just for the battery,

Build failed in Jenkins: plasma-workspace_master_qt5 #472

See Changes: [kde] Avoid hardcoded heights [kde] Use frameSVG's margins to calculate face position -- [...truncated 1238 lines...] Generating kdeplatformplugin.moc

Build failed in Jenkins: plasma-workspace_master_qt5 #471

See Changes: [notmart] ensure correct button is preselected -- [...truncated 1219 lines...] Generating moc_remotedirnotifymodule.cpp Built target plasma_engine_statusnotifieritem_automoc [

Build failed in Jenkins: plasma-workspace_master_qt5 #470

See Changes: [mklapetek] Revert "Polished the output sorting function" [mklapetek] [lookandfeel] Disable seconds on the lock screen/in InfoPane [mklapetek] [lookandfeel] Fix date in InfoPane/lockscreen -

Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118812/#review60420 --- Ship it! should quit now. if working correctly, should go in

Build failed in Jenkins: plasma-workspace_master_qt5 #469

See Changes: [sitter] fix install path for phonon platform plugin -- [...truncated 1220 lines...] Generating moc_statusnotifieritemservice.cpp Generating moc_statusnotifieritemsource.cpp [

Re: Review Request 118662: fix plugin install target for phonon platform plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118662/#review60415 --- Ship it! I confirm the plugin installs and loads correctly no

Build failed in Jenkins: plasma-desktop_master_qt5 #328

See Changes: [jlayt] Plasma - New Translations KCM [sebas] Specify translation domain in installed languages query [sebas] Move writeExports() into its own file [sebas] Various fixes [sebas] delete rc.cpp after we're done with i

Re: Review Request 118662: fix plugin install target for phonon platform plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118662/ --- (Updated June 18, 2014, 2:28 p.m.) Status -- This change has been ma

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 18, 2014, 2:28 p.m.) Status -- This change has been ma

Build failed in Jenkins: plasma-workspace_master_qt5 #468

See Changes: [notmart] delay corona creation -- [...truncated 1219 lines...] [ 18%] Generating wallpaperpackage.moc

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review60419 --- This review has been submitted with commit bd9b9ce0ebc99161ee

Re: Review Request 118662: fix plugin install target for phonon platform plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118662/#review60418 --- This review has been submitted with commit 6099e02691c19f9deb

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review60413 --- Ship it! Ship It! - Martin Gräßlin On June 18, 2014, 4:12

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/ --- (Updated June 18, 2014, 2:12 p.m.) Review request for Plasma, Chusslove I

Re: Review Request 118716: New Translations KCM

> On June 18, 2014, 1:49 p.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 119-125 > > > > > > does it have to be KMessageBoxes? Wouldn't KMessageWidget fit better in > > this case? T

Build failed in Jenkins: plasma-workspace_master_qt5 #467

See Changes: [kde] Fix password selection on failed login -- [...truncated 1256 lines...] [ 19%] Generating debuggerlaunchers.moc

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review60406 --- kcms/translations/kcmtranslations.cpp

Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118812/ --- (Updated June 18, 2014, 3:27 p.m.) Review request for Plasma. Changes -

Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

> On June 18, 2014, 3 p.m., David Edmundson wrote: > > shell/shellcorona.cpp, line 1232 > > > > > > just QCoreApplication::exit() > > Martin Gräßlin wrote: > I think it makes sense to have the error code. T

Re: Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118813/ --- (Updated June 18, 2014, 1:18 p.m.) Status -- This change has been ma

Re: Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118813/#review60402 --- This review has been submitted with commit d7d71e8a6660331494

Re: Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

> On June 18, 2014, 2:54 p.m., David Edmundson wrote: > > Are you not working on a patch to test at startup? > > > > Martin Gräßlin wrote: > yes I am, but this is orthogonal as it is in the frameworks. > > David Edmundson wrote: > Good point. > > I think maybe I should patch Qt

Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

> On June 18, 2014, 1 p.m., David Edmundson wrote: > > shell/shellcorona.h, line 87 > > > > > > private? > > Martin Gräßlin wrote: > are private slots invokable through QMetaObject::invokeMethod? sure. >From

Re: Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

> On June 18, 2014, 12:54 p.m., David Edmundson wrote: > > Are you not working on a patch to test at startup? > > > > Martin Gräßlin wrote: > yes I am, but this is orthogonal as it is in the frameworks. Good point. I think maybe I should patch Qt too. Currently a compile error in QSGMater

Re: Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118813/#review60399 --- Ship it! Ship It! - David Edmundson On June 18, 2014, 12:1

Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

> On June 18, 2014, 3 p.m., David Edmundson wrote: > > So this patch uses hasOpenGLShaderPrograms which doesn't work and > > QCoreApplication::exit() which doesn't work? > > That's both the major points of this patch, no? well, the hasOpenGLShaderProgram is addressed in https://codereview.qt-

Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118812/#review60395 --- So this patch uses hasOpenGLShaderPrograms which doesn't work

Re: Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

> On June 18, 2014, 2:54 p.m., David Edmundson wrote: > > Are you not working on a patch to test at startup? > > yes I am, but this is orthogonal as it is in the frameworks. - Martin --- This is an automatically generated e-mail. To rep

Re: Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118813/#review60394 --- Are you not working on a patch to test at startup? - David E

Build failed in Jenkins: plasma-workspace_master_qt5 #466

See Changes: [aleixpol] Battery plasmoid, code simplification [aleixpol] Small logic simplification -- [...truncated 1220 lines...] Generating progresslistmodel.moc

Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118813/ --- Review request for Plasma. Bugs: 336272 http://bugs.kde.org/show_bug.

Build failed in Jenkins: plasma-desktop_master_qt5 #327

See Changes: [notmart] animate toolbox appear/disappear -- [...truncated 774 lines...] Generating moc_kickoffproxymodel.cpp Generating moc_krunnermodel.cpp Generating moc_kuserproxy.cpp Gener

Build failed in Jenkins: plasma-desktop_master_qt5 #326

See Changes: [notmart] add a rough tooltip similar to plasma1 one -- [...truncated 755 lines...] Generating spellchecking.moc Generating moc_spellchecking.cpp Scanning dependencies of target

Build failed in Jenkins: plasma-workspace_master_qt5 #465

See Changes: [mklapetek] [digital-clock]Fix QML warning -- [...truncated 1267 lines...] :0:

Build failed in Jenkins: plasma-workspace_master_qt5 #464

See Changes: [aleixpol] Figure out delegates being cut at the top in Lock Screen, Login -- [...truncated 955 lines...] [ 12%] Automatic moc for target plasma_engine_statusnotifieritem Gener

Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118812/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Build failed in Jenkins: plasma-workspace_master_qt5 #463

See Changes: [aleixpol] Create a module to share components within the workspace -- [...truncated 1251 lines...] Generating backtraceparsergdb.moc

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/ --- (Updated June 18, 2014, 9:09 a.m.) Status -- This change has been di

Build failed in Jenkins: plasma-workspace_master_qt5 #462

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 1265 lines...] [ 19%] Automatic moc for target kglobalaccel5 Scanning dependencies of target kded_soliduiser