> On June 18, 2014, 3:33 p.m., Marco Martin wrote: > > would have preferred something private just for the battery, > > org.kde.plasma.workspace.components makes too easy to make it a dumpster... > > > > aaanyways, that's fine iff adding or modifying anything in > > org.kde.plasma.workspace.components will be something done with extreme > > care, and only when every other solution is exausted
Well, or we can consider it good to have a place to share components within the plasma workspace. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118799/#review60422 ----------------------------------------------------------- On June 17, 2014, 10:47 p.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118799/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 10:47 p.m.) > > > Review request for Plasma and Solid. > > > Repository: plasma-framework > > > Description > ------- > > This way we can share it between the Breeze lookandfeel and the Battery > plasmoid. At the moment it's forked. > > > Diffs > ----- > > src/declarativeimports/plasmaextracomponents/qml/BatteryIcon.qml > PRE-CREATION > src/declarativeimports/plasmaextracomponents/qml/qmldir c59e62f > > Diff: https://git.reviewboard.kde.org/r/118799/diff/ > > > Testing > ------- > > > Thanks, > > Aleix Pol Gonzalez > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
