> On June 18, 2014, 1:49 p.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 119-125 > > <https://git.reviewboard.kde.org/r/118716/diff/3/?file=281641#file281641line119> > > > > does it have to be KMessageBoxes? Wouldn't KMessageWidget fit better in > > this case?
Text seems pretty big for a message widget. It would easily overflow. I'm not really happy with KMB here, either (hat modal dialogs), but haven't found a better way. I'll give it some more thinking, but I'd rather not delay the merging of this KCM with it. > On June 18, 2014, 1:49 p.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, line 118 > > <https://git.reviewboard.kde.org/r/118716/diff/3/?file=281641#file281641line118> > > > > coding style Interestingly, this is broken in astyle-kdelibs. I've just corrected it, ran astyle-kdelibs over it, and it "corrects it back". - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review60406 ----------------------------------------------------------- On June 17, 2014, 4:26 p.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118716/ > ----------------------------------------------------------- > > (Updated June 17, 2014, 4:26 p.m.) > > > Review request for Plasma, Chusslove Illich and John Layt. > > > Repository: plasma-desktop > > > Description > ------- > > This is the second part of the replacement of the Locale KCM: Translations. > > This KCM complements the formats KCM, which sets the locale. With this KCM, > the user can configure GUI translations. > > The mechanism to set up the langhere, KF5-uage is the same as in the formats > KCM, while formats set LC_* and LANG, this KCM will set LANGUAGE. The UI is > roughly the same as in the previous "Locale", though here, KF5-compatible > mechanism (QLocale, ki18n, are used. > > This code has been written by John Layt, I've merely cleaned it up a bit, > added some missing features, tested it and am submitting it now for review. > > > Diffs > ----- > > kcms/CMakeLists.txt 76887e2 > kcms/formats/kcmformats.h 345fbb1 > kcms/formats/kcmformats.cpp 78cfb98 > kcms/formats/writeexports.h PRE-CREATION > kcms/translations/CMakeLists.txt PRE-CREATION > kcms/translations/Messages.sh PRE-CREATION > kcms/translations/kcmtranslations.h PRE-CREATION > kcms/translations/kcmtranslations.cpp PRE-CREATION > kcms/translations/kcmtranslationswidget.ui PRE-CREATION > kcms/translations/translations.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118716/diff/ > > > Testing > ------- > > Set up languages (x-test, others), re-logged in, languages correctly set up > for KF5 and console applications. > > > File Attachments > ---------------- > > KCM in systemsettings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
