Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:53 a.m., Martin Klapetek wrote: > > kcms/translations/kcmtranslations.cpp, line 49 > > > > > > Why are you having John's name translated? ;) Because he will be ??? in my language. -

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 9:46 p.m., David Edmundson wrote: > > startkde/ksyncdbusenv/ksyncdbusenv.cpp, line 48 > > > > > > if we do .asyncCall() and waitForFinished() > > > > we may as well just do .call() > >

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60042 --- Ship it! startkde/ksyncdbusenv/ksyncdbusenv.cpp

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/ --- (Updated June 13, 2014, 9:36 p.m.) Review request for Plasma and David Ed

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60041 --- startkde/startkde.cmake

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 3:14 p.m., David Edmundson wrote: > > I don't understand where this is useful unless you have a broken setup to > > begin with. > > > > Either you have your XDG paths set up properly for all users at which point > > you don't need this. > > Or you have DBus setup to load ap

Review Request 118734: Added MPRIS specifications Tracklist Interface

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118734/ --- Review request for Plasma, Emmanuel Pescosta, Shantanu Tushar, and Sinny Ku

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

> On June 13, 2014, 11:55 a.m., Sebastian Kügler wrote: > > To be honest, I'm not really sold on this font metric magic you're doing > > here. > > > > Could you attach screenshots old/new with different fonts? Perhaps some, > > with which the problem is well visible, one with it being hardly v

Re: Review Request 118733: Change installation path of sddm theme

> On June 13, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 118 > > > > > > Actually, shouldn't we have a find_package sddm and install it wherever > > it's installed? > > Bernd Steinhause

Re: Review Request 118733: Change installation path of sddm theme

> On June 13, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 118 > > > > > > Actually, shouldn't we have a find_package sddm and install it wherever > > it's installed? > > Bernd Steinhause

Re: Review Request 118733: Change installation path of sddm theme

> On June 13, 2014, 4:11 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 118 > > > > > > Actually, shouldn't we have a find_package sddm and install it wherever > > it's installed? At least currently,

Re: Review Request 118733: Change installation path of sddm theme

> On June 13, 2014, 4:22 p.m., David Edmundson wrote: > > Oh, well observed. Thanks. > > > > Do you have commit access? No, I don't have commit access. - Bernd --- This is an automatically generated e-mail. To reply, visit: https://git

Re: Review Request 118733: Change installation path of sddm theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118733/#review60028 --- Ship it! Oh, well observed. Thanks. Do you have commit acces

Jenkins build is back to normal : plasma-workspace_master_qt5 #413

See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118733: Change installation path of sddm theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118733/#review60023 --- CMakeLists.txt

Review Request 118733: Change installation path of sddm theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118733/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa

Re: Review Request 118636: Reinstate login & logout sounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118636/ --- (Updated June 13, 2014, 5:42 p.m.) Status -- This change has been ma

Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist

> On June 12, 2014, 5:54 p.m., Mark Gaiser wrote: > > Why would you do it this way? > > I mean, you should have a model in the C++ side and you should have a view > > (probably ListView). Then you can just ask the view the count: > > http://qt-project.org/doc/qt-5/qml-qtquick-listview.html#coun

Re: Review Request 118636: Reinstate login & logout sounds

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118636/#review60016 --- Ship it! Ship It! - David Edmundson On June 10, 2014, 1:05

Re: Review Request 118636: Reinstate login & logout sounds

> On June 10, 2014, 1:15 p.m., David Edmundson wrote: > > ksmserver/shutdown.cpp, line 501 > > > > > > Why do we have this if? What other state might we be in? > > Martin Klapetek wrote: > This is the origin

Re: Review Request 118732: Add xsession file for Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/ --- (Updated June 13, 2014, 2:22 p.m.) Review request for Plasma. Repositor

Re: Review Request 118732: Add xsession file for Plasma

> On June 13, 2014, 2:14 p.m., Hrvoje Senjan wrote: > > plasma.desktop.cmake, line 6 > > > > > > should be KDE instead of Plasma what happens if KDE makes another desktop? - Jonathan --

Re: Review Request 118732: Add xsession file for Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/#review60004 --- >From the other review.. Martin Klapetek 5 minutes ago (June

Re: Review Request 118732: Add xsession file for Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/#review60002 --- plasma.desktop.cmake

Re: Review Request 118729: add xsession file for Plasma Desktop

> On June 13, 2014, 2:51 p.m., Sebastian Kügler wrote: > > kde-plasma.desktop.cmake, line 7 > > > > > > workspace, we don't know at this point which shell is run. :) > > Jonathan Riddell wrote: > There is only

Re: Review Request 118729: add xsession file for Plasma Desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118729/#review59994 --- replacing with a file in plasma-workspace then https://git.re

Re: Review Request 118729: add xsession file for Plasma Desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118729/ --- (Updated June 13, 2014, 1:40 p.m.) Status -- This change has been di

Re: Review Request 118732: Add xsession file for Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/ --- (Updated June 13, 2014, 1:39 p.m.) Review request for Plasma. Repositor

Review Request 118732: Add xsession file for Plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 3:14 p.m., David Edmundson wrote: > > I don't understand where this is useful unless you have a broken setup to > > begin with. > > > > Either you have your XDG paths set up properly for all users at which point > > you don't need this. > > Or you have DBus setup to load ap

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 1:14 p.m., David Edmundson wrote: > > I don't understand where this is useful unless you have a broken setup to > > begin with. > > > > Either you have your XDG paths set up properly for all users at which point > > you don't need this. > > Or you have DBus setup to load ap

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 3:25 p.m., David Edmundson wrote: > > startkde/ksyncdbusenv/ksyncdbusenv.cpp, line 38 > > > > > > for (auto i = map.constBegin(); i != map.constEnd(); ++i) > > env.insert(i.key(), i.val

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review59985 --- startkde/ksyncdbusenv/ksyncdbusenv.cpp

Re: Review Request 118731: AbstractRunner: Add an iconForCategory virtual function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118731/#review59984 --- Ship it! src/abstractrunner.h

Re: Review Request 118729: add xsession file for Plasma Desktop

> On June 13, 2014, 12:51 p.m., Sebastian Kügler wrote: > > kde-plasma.desktop.cmake, line 7 > > > > > > workspace, we don't know at this point which shell is run. :) > > Jonathan Riddell wrote: > There is onl

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

> On June 13, 2014, 3:14 p.m., David Edmundson wrote: > > I don't understand where this is useful unless you have a broken setup to > > begin with. > > > > Either you have your XDG paths set up properly for all users at which point > > you don't need this. > > Or you have DBus setup to load ap

Review Request 118731: AbstractRunner: Add an iconForCategory virtual function

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118731/ --- Review request for Plasma. Repository: krunner Description ---

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review59979 --- I don't understand where this is useful unless you have a brok

Re: Review Request 118729: add xsession file for Plasma Desktop

On Friday 13 June 2014, Jonathan Riddell wrote: > > On June 13, 2014, 12:51 p.m., Sebastian Kügler wrote: > > > kde-plasma.desktop.cmake, line 7 > > > > > 5line7> > > > > > > workspace, we don't know at this point which

Re: Review Request 118729: add xsession file for Plasma Desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118729/#review59978 --- kde-plasma.desktop.cmake

Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa

Re: Review Request 118729: add xsession file for Plasma Desktop

> On June 13, 2014, 12:51 p.m., Sebastian Kügler wrote: > > kde-plasma.desktop.cmake, line 7 > > > > > > workspace, we don't know at this point which shell is run. :) There is only plasma desktop currently, I woul

Re: Review Request 118729: add xsession file for Plasma Desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118729/#review59976 --- kde-plasma.desktop.cmake

Review Request 118729: add xsession file for Plasma Desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118729/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 118722: add temporary Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118722/ --- (Updated June 13, 2014, 12:21 p.m.) Status -- This change has been d

Re: Review Request 118723: switch to Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118723/ --- (Updated June 13, 2014, 12:21 p.m.) Status -- This change has been m

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:49 a.m., Martin Gräßlin wrote: > > kcms/translations/CMakeLists.txt, line 13 > > > > > > new code shouldn't use kdelibs4support There doesn't seem to be an equivalent for translation change

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review59970 --- To be honest, I'm not really sold on this font metric magic yo

Re: Review Request 115431: Fix the numbers cut off problem in digital clock applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review59969 --- plasma/generic/applets/digital-clock/clock.cpp

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59968 --- kcms/translations/CMakeLists.txt

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 11:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break

Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118724/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 118716: New Translations KCM

> On June 13, 2014, 9:59 a.m., Martin Gräßlin wrote: > > kcms/translations/kcmtranslations.cpp, lines 54-55 > > > > > > this is a library. One may NEVER use setApplicationDomain in a library, > > it would break t

Re: Review Request 118723: switch to Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118723/#review59962 --- Ship it! Ship It! - Marco Martin On June 13, 2014, 10:44 a

Re: Review Request 118722: add temporary Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118722/#review59961 --- Ship it! fine, i would keep it also for the final release eve

Review Request 118722: add temporary Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118722/ --- Review request for Plasma. Repository: breeze Description --- add

Review Request 118723: switch to Next wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118723/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: dbus service files

On Fri, Jun 13, 2014 at 11:50:46AM +0200, Treeve Jelbert wrote: > I have just read .martin-graesslin's b;og on this subject, so I checked my > system > It appears that I have two services for krunner and fontinst with > conflicting > contents > > Shouldn't the kf5 ones be renamed? No because

Re: Review Request 118357: Disable the agenda part of the calendar

> On June 12, 2014, 12:25 p.m., Vishesh Handa wrote: > > I seem to have missed this change. > > > > The rationale behind this change is that there is no PIM support and > > therefore we should remove it. I'm sure you guys would have thought about > > the following points, but since the discuss

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59954 --- kcms/translations/kcmtranslations.cpp

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59952 --- kcms/translations/kcmtranslations.cpp

Re: Review Request 118716: New Translations KCM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review59949 --- +9000 for the ever present comments! kcms/translations/kcmtr

dbus service files

I have just read .martin-graesslin's b;og on this subject, so I checked my system $ ls -l /opt/qt5/share/dbus-1/services total 28 -rw-r--r-- 1 root root 68 Jun 6 16:15 kf5_org.kde.kuiserver.service -rw-r--r-- 1 root root 87 May 6 11:03 org.freedesktop.Akonadi.Control.service -rw-r--r-- 1 root r

Re: Review Request 118357: Disable the agenda part of the calendar

> On June 12, 2014, 10:25 a.m., Vishesh Handa wrote: > > I seem to have missed this change. > > > > The rationale behind this change is that there is no PIM support and > > therefore we should remove it. I'm sure you guys would have thought about > > the following points, but since the discuss

Re: Re: Request to MacBook users

On Friday 13 June 2014 10:02:27 Martin Klapetek wrote: > On Fri, Jun 13, 2014 at 9:02 AM, Martin Gräßlin wrote: > > What I see on my old MacBook is: > > * Expose: XF86LaunchA > > * Dashboard: XF86LaunchB > > MacBook Pro 2011 - the same. for Present Windows created: https://git.reviewboard.kde.or

Re: Review Request 118357: Disable the agenda part of the calendar

> On June 12, 2014, 12:25 p.m., Vishesh Handa wrote: > > I seem to have missed this change. > > > > The rationale behind this change is that there is no PIM support and > > therefore we should remove it. I'm sure you guys would have thought about > > the following points, but since the discuss

Re: Review Request 118665: Avoid invalid read in ShadowHelper destructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118665/ --- (Updated June 13, 2014, 10:40 a.m.) Review request for Plasma and Hugo Pe

Re: Request to MacBook users

Am Freitag, 13. Juni 2014, 10.22:48 schrieb Martin Gräßlin: Morning again > > > with the new kglobalaccel we can have multiple global shortcuts for the > > > same action. Because of that I would like to map all the special keys > > > for Expose, Dashboard, etc from a MacBook to our matching > > >

Re: Re: Request to MacBook users

On Friday 13 June 2014 10:26:07 Mario Fux wrote: > Am Freitag, 13. Juni 2014, 09.02:55 schrieb Martin Gräßlin: > > Dear MacBook users, > > Morning Martin > > > with the new kglobalaccel we can have multiple global shortcuts for the > > same action. Because of that I would like to map all the spec

Re: Request to MacBook users

Am Freitag, 13. Juni 2014, 09.02:55 schrieb Martin Gräßlin: > Dear MacBook users, Morning Martin > with the new kglobalaccel we can have multiple global shortcuts for the > same action. Because of that I would like to map all the special keys for > Expose, Dashboard, etc from a MacBook to our mat

Re: Request to MacBook users

On Fri, Jun 13, 2014 at 9:02 AM, Martin Gräßlin wrote: > > What I see on my old MacBook is: > * Expose: XF86LaunchA > * Dashboard: XF86LaunchB > MacBook Pro 2011 - the same. Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plas

Re: Review Request 118694: X11/XCB becomes a required component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118694/#review59930 --- This review has been submitted with commit 4889a12629520f542e

Re: Review Request 118694: X11/XCB becomes a required component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118694/ --- (Updated June 13, 2014, 7:11 a.m.) Status -- This change has been ma

Request to MacBook users

Dear MacBook users, with the new kglobalaccel we can have multiple global shortcuts for the same action. Because of that I would like to map all the special keys for Expose, Dashboard, etc from a MacBook to our matching functionality. But for that I need the key code: please run the tool xev,