----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118731/#review59984 -----------------------------------------------------------
Ship it! src/abstractrunner.h <https://git.reviewboard.kde.org/r/118731/#comment41763> would come a bit more natural to me "categoryIcon" but also iconForCategory is ok i guess - Marco Martin On June 13, 2014, 1:15 p.m., Vishesh Handa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118731/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 1:15 p.m.) > > > Review request for Plasma. > > > Repository: krunner > > > Description > ------- > > This function is mostly used in the KCM in order to provide nice looking > icons when displaying all the categories for the runners. > > This is the last patch I need in the krunner repo for a decent KCM. > > > Diffs > ----- > > src/abstractrunner.h 0958a28 > src/abstractrunner.cpp a48fd0c > > Diff: https://git.reviewboard.kde.org/r/118731/diff/ > > > Testing > ------- > > > Thanks, > > Vishesh Handa > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
