----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115431/#review59969 -----------------------------------------------------------
plasma/generic/applets/digital-clock/clock.cpp <https://git.reviewboard.kde.org/r/115431/#comment41750> Don't do that. We're trying to avoid subpixel alignment, and this is going to introduce this kind of issues. No F please. plasma/generic/applets/digital-clock/clock.cpp <https://git.reviewboard.kde.org/r/115431/#comment41753> "overbig" is not a word, you can use "too wide" here. plasma/generic/applets/digital-clock/clock.cpp <https://git.reviewboard.kde.org/r/115431/#comment41752> Coding style, brackets also around single line if statements. (also on following lines) plasma/generic/applets/digital-clock/clock.cpp <https://git.reviewboard.kde.org/r/115431/#comment41751> Same here: no float. - Sebastian Kügler On March 18, 2014, 12:56 p.m., Yichao Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115431/ > ----------------------------------------------------------- > > (Updated March 18, 2014, 12:56 p.m.) > > > Review request for Plasma. > > > Bugs: 228902 > http://bugs.kde.org/show_bug.cgi?id=228902 > > > Repository: kde-workspace > > > Description > ------- > > For bug, see > https://bugs.launchpad.net/ubuntu/+source/kde-workspace/+bug/1052059 and > https://bugs.kde.org/show_bug.cgi?id=228902 > > The problem is that in original code, it always uses 23:59 to calculate the > width of the text. However, in some font, AM is wider than PM, and 0 is > wider than 2 and 5. That causes some fonts been cropped. > > > Diffs > ----- > > plasma/generic/applets/digital-clock/clock.cpp f26e328 > > Diff: https://git.reviewboard.kde.org/r/115431/diff/ > > > Testing > ------- > > > Thanks, > > Yichao Zhou > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
