---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117393/#review55931
---
Looks good. Maybe add a feature info bound to the build option
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117606/
---
Review request for Plasma.
Repository: plasma-framework
Description
---
Hi,
A patch was merged today that makes it possible to use kquitapp5 again.
It's especially interesting to use it to make sure that the settings will
be saved.
You can close plasma shell now by calling:
kquitapp5 plasma_shell
Note the underscore (_).
Cheers!
Aleix
___
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117393/
---
(Updated April 16, 2014, 8:28 p.m.)
Review request for kwin and Plasma.
> On April 16, 2014, 6:48 p.m., Martin Gräßlin wrote:
> > as all unit tests use ecm_mark_as_test the tests should not be built even
> > if they are included in the CMakeLists.txt. Given that I think that change
> > is not needed at all. If there are tests which do not use ecm_mark_as_test
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117601/
---
(Updated April 16, 2014, 9:21 p.m.)
Review request for Plasma.
Changes
> On April 16, 2014, 4:48 p.m., Martin Gräßlin wrote:
> > as all unit tests use ecm_mark_as_test the tests should not be built even
> > if they are included in the CMakeLists.txt. Given that I think that change
> > is not needed at all. If there are tests which do not use ecm_mark_as_test
> >
> On April 16, 2014, 6:53 p.m., Marco Martin wrote:
> > uhm, is this use of symlinks actually widespread/common or is some obscure
> > corner case?
>
> Martin Klapetek wrote:
> No idea; better safe than sorry was what I was thinking.
yeah, let's go for it
- Marco
--
> On April 16, 2014, 8:53 p.m., Marco Martin wrote:
> > uhm, is this use of symlinks actually widespread/common or is some obscure
> > corner case?
No idea; better safe than sorry was what I was thinking.
- Martin
---
This is an automa
> On April 16, 2014, 4:48 p.m., Martin Gräßlin wrote:
> > as all unit tests use ecm_mark_as_test the tests should not be built even
> > if they are included in the CMakeLists.txt. Given that I think that change
> > is not needed at all. If there are tests which do not use ecm_mark_as_test
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117601/#review55907
---
uhm, is this use of symlinks actually widespread/common or is
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117601/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
> On April 16, 2014, 4:48 p.m., Martin Gräßlin wrote:
> > as all unit tests use ecm_mark_as_test the tests should not be built even
> > if they are included in the CMakeLists.txt. Given that I think that change
> > is not needed at all. If there are tests which do not use ecm_mark_as_test
> >
> On April 16, 2014, 6:48 p.m., Martin Gräßlin wrote:
> > as all unit tests use ecm_mark_as_test the tests should not be built even
> > if they are included in the CMakeLists.txt. Given that I think that change
> > is not needed at all. If there are tests which do not use ecm_mark_as_test
> >
> On April 16, 2014, 4:48 p.m., Martin Gräßlin wrote:
> > as all unit tests use ecm_mark_as_test the tests should not be built even
> > if they are included in the CMakeLists.txt. Given that I think that change
> > is not needed at all. If there are tests which do not use ecm_mark_as_test
> >
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117393/#review55896
---
as all unit tests use ecm_mark_as_test the tests should not be
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117565/#review55881
---
This review has been submitted with commit
29e485f793ef818c83
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117565/
---
(Updated April 16, 2014, 2:28 p.m.)
Status
--
This change has been m
> On April 15, 2014, 1:43 p.m., Àlex Fiestas wrote:
> > Not sure if exporting all Slots is what we want, but I think we do want to
> > have Quit exposed in dbus.
there is only one slot, and we can't really change QCoreApplication at this
point.
- David
-
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117565/#review55880
---
Ship it!
Ship It!
- David Edmundson
On April 14, 2014, 4:1
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117586/
---
(Updated April 16, 2014, 12:49 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117586/#review55869
---
This review has been submitted with commit
eea39156c3cd4c63b9
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117586/#review55868
---
Ship it!
Ship It!
- David Edmundson
On April 16, 2014, 11:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117586/
---
Review request for Plasma, David Edmundson and Marco Martin.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117417/
---
(Updated April 16, 2014, 11:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117414/#review55865
---
This review has been submitted with commit
aacb22a1f92e42842c
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117417/#review55866
---
This review has been submitted with commit
084d81346f67dd0cb9
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117414/
---
(Updated April 16, 2014, 11:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117414/#review55864
---
Unfortunately I need to re-add the linking to kdelibs4support
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117584/
---
Review request for Plasma.
Repository: plasma-workspace
Description
---
On Wednesday 16 April 2014 00:40:42 Aleix Pol wrote:
>
> I don't think we can just tell people to use wmsystemtray. We should find
> some way to integrate it, at least, maybe have a plasmoid that requests the
> space and puts it in a smart place or something.
>
> Aleix
wl, if it's xembedding
> On April 14, 2014, 12:58 p.m., Sinny Kumari wrote:
> > checking only url of runtimeData will work only when PMC is launched and
> > nothing has been played. You need to handle many other cases like when
> > media get stopped, next/prev shouldn't be enabled until and unless current
> > media
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117411/
---
(Updated April 16, 2014, 7:09 a.m.)
Status
--
This change has been m
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117411/#review55837
---
This review has been submitted with commit
e423dd17808d634f38
34 matches
Mail list logo
