> On April 14, 2014, 12:58 p.m., Sinny Kumari wrote: > > checking only url of runtimeData will work only when PMC is launched and > > nothing has been played. You need to handle many other cases like when > > media get stopped, next/prev shouldn't be enabled until and unless current > > media is getting played from playlist etc
I am checking the "playlistModel.currentIndex != -1" condition for the next and previous buttons. For the rest, I think checking "runtimeData.url" works fine. But with this, next and prev get disabled when a new playlist is selected, and do not get enabled unless a song from that playlist is selected. Expected behavior ? - R.Harish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review55718 ----------------------------------------------------------- On April 12, 2014, 3:23 p.m., R.Harish Navnit wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116874/ > ----------------------------------------------------------- > > (Updated April 12, 2014, 3:23 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 330990 and Bug > http://bugs.kde.org/show_bug.cgi?id=330990 > http://bugs.kde.org/show_bug.cgi?id=Bug > > > Repository: plasma-mediacenter > > > Description > ------- > > Now the next and previous buttons do not work unless a media is playing. > > > Diffs > ----- > > mediaelements/mediacontroller/MediaController.qml 2fce0a0 > mediaelements/playlist/Playlist.qml 5dde297 > > Diff: https://git.reviewboard.kde.org/r/116874/diff/ > > > Testing > ------- > > I've done the testing for this patch. > > These are the steps that I followed. > 1. Added a new playlist and added a few songs to the playlist. > 2. Re-opened Plasma Media Center > 3. Clicked the Next and Previous buttons. > 4. Nothing was played. > 5. Selected a song from the list and then tested the next and previous > buttons. > 6. The buttons worked seamlessly. > > > Thanks, > > R.Harish Navnit > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
