----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/#review55931 -----------------------------------------------------------
Looks good. Maybe add a feature info bound to the build option indicating whether testing is build. - Martin Gräßlin On April 16, 2014, 10:28 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117393/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 10:28 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > Don't try to build tests if QtTest is not found. > > > Diffs > ----- > > CMakeLists.txt 35fb9ac3b0f8506e6f0fd92b48ba60e83524f212 > kcmkwin/kwincompositing/CMakeLists.txt > 8eb170bedd32f04f5d2cc0fbd3079758e6138cc6 > > Diff: https://git.reviewboard.kde.org/r/117393/diff/ > > > Testing > ------- > > Builds. Tests pass (when QtTest is found). > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
