> On April 16, 2014, 6:48 p.m., Martin Gräßlin wrote: > > as all unit tests use ecm_mark_as_test the tests should not be built even > > if they are included in the CMakeLists.txt. Given that I think that change > > is not needed at all. If there are tests which do not use ecm_mark_as_test > > they should get fixed. > > > > From documentation: > > > > # ECMMarkAsTest > > # ------------- > > # > > # Marks a target as only being required for tests. > > # > > # :: > > # > > # ecm_mark_as_test(<target1> [<target2> [...]]) > > # > > # This will cause the specified targets to not be built unless either > > # BUILD_TESTING is set to ON or the user invokes the ``buildtests`` target. > > # > > # BUILD_TESTING is created as a cache variable by the CTest module and by > > the > > # :kde-module:`KDECMakeSettings` module. > > > > Michael Palimaka wrote: > That's true (and it seems there's some stuff here and there that should > use it), but configure will still fail if QtTest is not present.
> configure will still fail if QtTest is not present how much is that a problem? Do your users not have it installed? - Martin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117393/#review55896 ----------------------------------------------------------- On April 7, 2014, 4:50 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117393/ > ----------------------------------------------------------- > > (Updated April 7, 2014, 4:50 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwin > > > Description > ------- > > Add option to disable building tests, and move the QtTest dependency to be > required only for tests. > > > Diffs > ----- > > CMakeLists.txt 35fb9ac3b0f8506e6f0fd92b48ba60e83524f212 > autotests/CMakeLists.txt 475a7a5f9013ed16d37777bc05e9cba2ad033338 > kcmkwin/kwincompositing/CMakeLists.txt > 8eb170bedd32f04f5d2cc0fbd3079758e6138cc6 > kcmkwin/kwincompositing/test/CMakeLists.txt PRE-CREATION > libkwineffects/CMakeLists.txt 0544b0d441f3685240160f15e6c9890c8a92fec1 > libkwineffects/autotests/CMakeLists.txt > 8973545cc21b010f1430cf7df20a29da5b14ab43 > tabbox/CMakeLists.txt 76ba3a2499ca142bb82109db9d7239001ed7157e > tabbox/autotests/CMakeLists.txt 4e83fa7524483d64ea149f0eb1818ea9f61cffe0 > > Diff: https://git.reviewboard.kde.org/r/117393/diff/ > > > Testing > ------- > > Builds. Tests pass (when enabled). > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
