Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/ --- (Updated Dec. 11, 2013, 8:06 a.m.) Review request for Plasma and Sebastian

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Martin Gräßlin
> On Dec. 10, 2013, 3:40 p.m., Sebastian Kügler wrote: > > src/declarativeimports/core/dialog.h, line 93 > > > > > > READ hideOnWindowDeactivate? > > > > Or is there a reason to use is*** here, such as an

Review Request 114396: Fix KWindowSystem_X11 changeWindow signal emitting

2013-12-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114396/ --- Review request for KDE Frameworks and Plasma. Repository: kdelibs Descri

Re: Review Request 114389: Add KF5 prefix to Plasma and PlasmaQuick libs

2013-12-10 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114389/#review45508 --- Ship it! Ship It! - Kevin Ottens On Dec. 10, 2013, 4:51 p.m

Re: Review Request 114389: Add KF5 prefix to Plasma and PlasmaQuick libs

2013-12-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114389/#review45489 --- Ship it! Ship It! - Sebastian Kügler On Dec. 10, 2013, 4:51

Re: Review Request 114388: Remove the scripting support from ksysguard and hence remove Qt5WebkitWidgets dep from kde-workspace

2013-12-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114388/ --- (Updated Dec. 10, 2013, 10:37 p.m.) Status -- This change has been di

Re: Review Request 114382: Reduce plasma warnings

2013-12-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114382/#review45485 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 10, 2013, 3:

Re: Review Request 114388: Remove the scripting support from ksysguard and hence remove Qt5WebkitWidgets dep from kde-workspace

2013-12-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114388/#review45484 --- I think I was not quite clear enough here, and caused a misunde

Re: Review Request 114388: Remove the scripting support from ksysguard and hence remove Qt5WebkitWidgets dep from kde-workspace

2013-12-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114388/ --- (Updated Dec. 10, 2013, 10:24 p.m.) Review request for Plasma and Sebastia

Review Request 114389: Add KF5 prefix to Plasma and PlasmaQuick libs

2013-12-10 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114389/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framework

Review Request 114388: Remove the scripting support from ksysguard and hence remove Qt5WebkitWidgets dep from kde-workspace

2013-12-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114388/ --- Review request for Plasma and Sebastian Kügler. Repository: kde-workspace

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/#review45471 --- This review has been submitted with commit 5edfe04af85fb3302bf

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/ --- (Updated Dec. 10, 2013, 3:57 p.m.) Status -- This change has been mar

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/#review45469 --- Ship it! Ship It! - Sebastian Kügler On Dec. 10, 2013, 3:17

Review Request 114382: Reduce plasma warnings

2013-12-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114382/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Sebastian Kügler
> On Dec. 10, 2013, 2:40 p.m., Sebastian Kügler wrote: > > src/declarativeimports/core/dialog.h, line 93 > > > > > > READ hideOnWindowDeactivate? > > > > Or is there a reason to use is*** here, such as an

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/ --- (Updated Dec. 10, 2013, 8:47 p.m.) Review request for Plasma and Sebastian

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Bhushan Shah
> On Dec. 10, 2013, 8:30 p.m., Sebastian Kügler wrote: > > plasma/generic/dataengines/share/shareengine.cpp, line 118 > > > > > > I don't see where this json file is generated. Is it at all? data/CMakeLists.txt

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Martin Gräßlin
> On Dec. 10, 2013, 3:40 p.m., Sebastian Kügler wrote: > > So you mean that whether or not to set it depends on KWin's focuspolicy and > > should be taken into account in CompactApplet.qml? no, it's just a very easy way to see when it should not be hidden. E.g. if you need to have the mouse in

Re: Review Request 114380: Port share dataengine

2013-12-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/#review45461 --- plasma/generic/dataengines/share/share_package.cpp

Review Request 114380: Port share dataengine

2013-12-10 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/ --- Review request for Plasma and Sebastian Kügler. Repository: kde-workspace

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/#review45459 --- src/declarativeimports/core/dialog.h

Re: Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/#review45460 --- So you mean that whether or not to set it depends on KWin's foc

Review Request 114378: Add a hideOnWindowDeactivate property to PlasmaCore.Dialog

2013-12-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/ --- Review request for Plasma and Sebastian Kügler. Repository: plasma-framewo

Re: activities and scripting

2013-12-10 Thread Nowardev-Team
i have 1920x 1080 resolution ,if i chose the same wallpaper on =>right click on the destkop=>desktop settings => it says correctly 1920x1080 which is my own resolution and if i select it it looks good here it is http://wstaw.org/m/2013/12/10/codegnome4.jpeg i have managed to remove this behavio