----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114388/#review45484 -----------------------------------------------------------
I think I was not quite clear enough here, and caused a misunderstanding. We should make the scripting support OPTIONAL, instead of REQUIRED. I hoped to be able to do that without #ifdef, by just not including a subdirectory, for example. Seems this isn't possible here, and we'd actually cause a BIC change whether webkit is found or not. That's not good, as it causes non-obvious build problems (i.e. the thing we wanted to avoid). If it's not possible without #ifdef or BIC change, disable the whole library based on webkit being found or not. That will make it a whole lot cleaner and clearer to the user. Sorry for causing confusion here. :/ - Sebastian Kügler On Dec. 10, 2013, 4:54 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114388/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 4:54 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: kde-workspace > > > Description > ------- > > As discussed on IRC #kde-devel > > > Diffs > ----- > > CMakeLists.txt 9841bbd > libs/ksysguard/processui/CMakeLists.txt 07ddbef > libs/ksysguard/processui/ksysguardprocesslist.h 97116be > libs/ksysguard/processui/ksysguardprocesslist.cpp 0f6220f > > Diff: http://git.reviewboard.kde.org/r/114388/diff/ > > > Testing > ------- > > compiles > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
