----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114378/#review45460 -----------------------------------------------------------
So you mean that whether or not to set it depends on KWin's focuspolicy and should be taken into account in CompactApplet.qml? src/declarativeimports/core/dialog.h <http://git.reviewboard.kde.org/r/114378/#comment32411> READ hideOnWindowDeactivate? Or is there a reason to use is*** here, such as an API collision? - Sebastian Kügler On Dec. 10, 2013, 2:14 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114378/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 2:14 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: plasma-framework > > > Description > ------- > > This property is meant to bring back the functionality provided by > PopupApplet. If the property is set to true the dialog gets hidden when it > loses focus. > > > Diffs > ----- > > src/declarativeimports/core/dialog.h d612882 > src/declarativeimports/core/dialog.cpp 04ef7e4 > > Diff: http://git.reviewboard.kde.org/r/114378/diff/ > > > Testing > ------- > > Tested with CompactApplet in the desktop qmlpackages. It works, but it > shouldn't be set to true there. It needs to be set only on the windows it > should have. To test I recommend to switch to focus follows mouse. Whenever > the window closes in an unexpected way, it's wrong. > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
