----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114380/#review45461 -----------------------------------------------------------
plasma/generic/dataengines/share/share_package.cpp <http://git.reviewboard.kde.org/r/114380/#comment32412> Don't we need to call initPackage here or is that done later? (Haven't looked at the entire engine code.) plasma/generic/dataengines/share/share_package.cpp <http://git.reviewboard.kde.org/r/114380/#comment32415> Use QStringLiteral around the strings here plasma/generic/dataengines/share/shareengine.cpp <http://git.reviewboard.kde.org/r/114380/#comment32413> I don't see where this json file is generated. Is it at all? plasma/generic/dataengines/share/shareservice.cpp <http://git.reviewboard.kde.org/r/114380/#comment32414> Use QStringLiteral around "mainscript" - Sebastian Kügler On Dec. 10, 2013, 2:54 p.m., Bhushan Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114380/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2013, 2:54 p.m.) > > > Review request for Plasma and Sebastian Kügler. > > > Repository: kde-workspace > > > Description > ------- > > Will port away from KDE4Support soon > > > Diffs > ----- > > plasma/generic/dataengines/CMakeLists.txt 11a90d1 > plasma/generic/dataengines/share/CMakeLists.txt a68ed0d > plasma/generic/dataengines/share/data/CMakeLists.txt PRE-CREATION > plasma/generic/dataengines/share/plugin_share_package.cpp ac81a31 > plasma/generic/dataengines/share/share_package.h 00df488 > plasma/generic/dataengines/share/share_package.cpp a31c6c5 > plasma/generic/dataengines/share/shareengine.cpp 86c308f > plasma/generic/dataengines/share/shareservice.cpp b789439 > > Diff: http://git.reviewboard.kde.org/r/114380/diff/ > > > Testing > ------- > > works as expected > > > Thanks, > > Bhushan Shah > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
