Re: Review Request: Status notifier item data engine

2010-03-17 Thread Matthieu Gallien
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3266/ --- (Updated 2010-03-17 23:12:45.067867) Review request for Plasma. Changes --

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Zack Rusin
> On 2010-03-17 12:31:22, Marco Martin wrote: > > just by a quick test, the physics seems to work indeed better, it just > > still has some quirks: > > > > - scrollbars aren't syncronized when dragging (yeah i know it needs a mode > > without scrollbars but i would keep them on the desktop) >

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/ --- (Updated 2010-03-17 22:20:25.287357) Review request for Plasma. Changes --

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Marco Martin
> On 2010-03-17 12:31:22, Marco Martin wrote: > > just by a quick test, the physics seems to work indeed better, it just > > still has some quirks: > > > > - scrollbars aren't syncronized when dragging (yeah i know it needs a mode > > without scrollbars but i would keep them on the desktop) >

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Zack Rusin
> On 2010-03-17 12:31:22, Marco Martin wrote: > > just by a quick test, the physics seems to work indeed better, it just > > still has some quirks: > > > > - scrollbars aren't syncronized when dragging (yeah i know it needs a mode > > without scrollbars but i would keep them on the desktop) >

Re: Review Request: Load webslice params from desktop file

2010-03-17 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3315/#review4540 --- this is a clever approach, however i think it does it in a sort of hac

Re: Review Request: Load webslice params from desktop file

2010-03-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3315/#review4539 --- I like the concept very much. comments from webslice authors? :) - Ma

Review Request: Load webslice params from desktop file

2010-03-17 Thread Petri Damstén
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3315/ --- Review request for Plasma. Summary --- Load webslice params from desktop fi

Re: Review Request: Status notifier item data engine

2010-03-17 Thread Marco Martin
On Wednesday 17 March 2010, Aaron J. Seigo wrote: > On March 17, 2010, Matthieu Gallien wrote: > > Should I request an SVN account and put you Marco as the referee ? > > +1 +1 from me as well :) Cheers, Marco Martin ___ Plasma-devel mailing list Plasma-

Re: Review Request: Status notifier item data engine

2010-03-17 Thread Aaron J. Seigo
On March 17, 2010, Matthieu Gallien wrote: > Should I request an SVN account and put you Marco as the referee ? +1 -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks _

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Zack Rusin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/ --- (Updated 2010-03-17 14:31:13.742901) Review request for Plasma. Changes --

Re: Review Request: Status notifier item data engine

2010-03-17 Thread Matthieu Gallien
> On 2010-03-12 11:58:14, Marco Martin wrote: > > apart some style issues this should go in because the modifications are > > already too big (Aurelien has a patch on it too, you should also update to > > include it one he committed) > > Matthieu Gallien wrote: > I will post an updated pat

Re: Review Request: Patch to use the data engine for status notifier items

2010-03-17 Thread Matthieu Gallien
> On 2010-03-17 12:13:33, Marco Martin wrote: > > what is the status of this thing? > > is the current one meant to be the final or still needs something? Hello, It is not final. It is buggy. The icons are not showing up for item like KMix. It is showing up for nepomuk only after Nepomuk starts

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Artur Souza (MoRpHeUz)
On Wednesday 17 March 2010, 09:20 igorto wrote: > Instead of change the ScrollWidget code you should have a look in > plasma/private/kineticscroll.* because there is the old kinetic scroll > implementation and it is used by others classes(like plasma/webview) and > would be difficult maintain two d

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Marco Martin
> On 2010-03-17 12:20:55, igorto wrote: > > Instead of change the ScrollWidget code you should have a look in > > plasma/private/kineticscroll.* because there is the old kinetic scroll > > implementation and it is used by others classes(like plasma/webview) and > > would be difficult maintain

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/#review4532 --- just by a quick test, the physics seems to work indeed better, it just

Re: Review Request: Rewrite kinetic scrolling on ScrollWidget

2010-03-17 Thread igorto
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3312/#review4534 --- Instead of change the ScrollWidget code you should have a look in pla

Re: Review Request: Patch to use the data engine for status notifier items

2010-03-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3265/#review4533 --- what is the status of this thing? is the current one meant to be the f