----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3315/#review4540 -----------------------------------------------------------
this is a clever approach, however i think it does it in a sort of hackish manner by adding more entries to the ksycoca database. since these would be distributed as packages via get hot new stuff, they really ought to -be- Packages. what would be very nice, imho, is the ability to associate a Package with a C++ driven plasmoid. this would open up a whole bunch of possibilities, including this one. off the top of my head: we could add one new property to the Plasma/Applet service type which would define the name of the package to use (X-Plasma-Package?); in the C++ case this would serve the same purpose as the X-KDE-PluginInfo-Name= entry. it would define a name that would be looked for in a well known location (apps/plasma/packages? so as not to conflict with apps/plasma/plasmoids/?) then webslice could simply include a .desktop file describing the "package format" (which would be beyond simple; either being empty if the values stored in the .desktop file or contain a path to a config file such as "config" which would be a kconfig-readable file and which would be found as contents/config in the package) and it should all Just Work(tm) from there. WebSlice could see if package() returns a non-null pointer and if so, ask it for the config file that contains the values. /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/plasma-webslice.desktop <http://reviewboard.kde.org/r/3315/#comment3993> that looks wrong :) it probably works, but if we do any introspection of ksycoca we'll end up with "Plasma webslice" as a Comment for the Plasma/Applet ServiceType - Aaron On 2010-03-17 16:45:13, Petri Damstén wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3315/ > ----------------------------------------------------------- > > (Updated 2010-03-17 16:45:13) > > > Review request for Plasma. > > > Summary > ------- > > Load webslice params from desktop file so webslices can be shared in > kde-look.org as plasmoid packages (package containing only a custom desktop > file). > > > Diffs > ----- > > /trunk/KDE/kdeplasma-addons/applets/webslice/kgraphicswebslice.cpp 1104337 > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/CMakeLists.txt 1104337 > > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/plasma-applet-webslice.desktop > 1104337 > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/plasma-webslice.desktop > PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/webslice.h 1104337 > /trunk/KDE/kdeplasma-addons/applets/webslice/plasma/webslice.cpp 1104337 > > Diff: http://reviewboard.kde.org/r/3315/diff > > > Testing > ------- > > > Thanks, > > Petri > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
