Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

d I'd rather add a return than increase indentation, thus making hg blame useless at finding out why the indented code was written. - Vadim ------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.c

Re: [opensource-dev] Review Request: STORM-1427 Crash in world map when region name search is empty (Assert fails in LLWorldMapMessage::processMapBlockReply)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/432/ --- (Updated Aug. 8, 2011, 10:51 a.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/433/ --- Review request for Viewer. Summary --- Disallow showing URL-like avata

[opensource-dev] Review Request: STORM-1546 Crash in LLSecAPIBasicHandler::getCertificateStore

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/435/ --- Review request for Viewer and David Parks. Summary --- Fixed a crash c

Re: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/433/ --- (Updated Aug. 10, 2011, 8:25 a.m.) Review request for Viewer and Richard Ne

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/#review962 --- The patch introduces regressions: * The /me prefix is not handled

Re: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

;s If I'm not mistaken, this regexp would not allow more than one character between the tags. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/433/#review963 -----

Re: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

> > or use nested tags, but it would seem to be better to use: > > > > boost::regex(".?") > > > > this will consume as few characters as possible between the opening and > > closing tags, thus allowing multiple "nolink"s &g

Re: [opensource-dev] Review Request: STORM-632 URL-like resident display name is shown as clickable HTTP URL in various places (additional fix)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/433/ --- (Updated Aug. 12, 2011, 5:38 a.m.) Review request for Viewer and Richard Ne

[opensource-dev] Review Request: STORM-1554 Untranslatable gesture: /bow1

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/439/ --- Review request for Viewer. Summary --- Fixed typo in a gesture name.

Re: [opensource-dev] Review Request: Respect --no-verify-ssl-cert option

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/438/#review967 --- Ship it! Looks good. - Vadim On Aug. 11, 2011, 8:26 p.m., Ston

Re: [opensource-dev] Review Request: [STORM-56] As Builder, I want more decimal places allowed in the Build tool so that I can more precisely align small prims.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/424/#review968 --- Code looks fine to me, but if you play with the rotation spinners

Re: [opensource-dev] Review Request: /me emote doubles name in chat history

> On Aug. 11, 2011, 11:47 a.m., Vadim ProductEngine wrote: > > indra/newview/llchathistory.cpp, line 929 > > <http://codereview.secondlife.com/r/419/diff/1/?file=6814#file6814line929> > > > > Agree with Boroondas that replacing /me with the sender name and t

Re: [opensource-dev] Review Request: VWR-26393 /me emote doubles name in chat history

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/419/ --- (Updated Aug. 15, 2011, 7:19 a.m.) Review request for Viewer. Summary (up

[opensource-dev] Review Request: STORM-782 Unnecessary 'Compress snapshots to disk' menu item is presented in Advanced menu

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/440/ --- Review request for Viewer. Summary --- Removed the useless 'Compress s

[opensource-dev] Review Request: STORM-1041 Removed clothes come back to haunt me

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/441/ --- Review request for Viewer and Nyx Linden. Summary --- The "Remove all

[opensource-dev] Review Request: STORM-793 Offered URL-like named object is displayed as a HTTP URL in the llGiveInventory

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/442/ --- Review request for Viewer. Summary --- Disallowed parsing HTTP URLs in

Re: [opensource-dev] Review Request: STORM-793 Offered URL-like named object is displayed as a HTTP URL in the llGiveInventory

n the translations? Ah, right. Thanks, will fix. On Aug. 16, 2011, 1:19 p.m., Vadim ProductEngine wrote: > > > The fix may look weird because we seem to wrap a SLURL with > > > ... tags. > > > But actually there is no SLURL, there's just an object name. > >

Re: [opensource-dev] Review Request: STORM-793 Offered URL-like named object is displayed as a HTTP URL in the llGiveInventory

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/442/ --- (Updated Aug. 17, 2011, 3:21 a.m.) Review request for Viewer. Changes ---

[opensource-dev] Review Request: STORM-1268 Viewer update resets some viewer settings

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/443/ --- Review request for Viewer and Richard Nelson. Summary --- Bug: Setting

[opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/444/ --- Review request for Viewer and Richard Nelson. Summary --- In busy mode

Re: [opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/444/ --- (Updated Aug. 22, 2011, 4:10 a.m.) Review request for Viewer and Richard Ne

[opensource-dev] Review Request: STORM-1542 Update viewer 2 search url back to search.sl.com

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/446/ --- Review request for Viewer. Summary --- Changed search URL back from se

[opensource-dev] Review Request: STORM-1566 Sidebar windows no longer detach by right-clicking the tab

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/447/ --- Review request for Viewer. Summary --- Reason: wrong name was used to

[opensource-dev] Review Request: STORM-555 As a LL developer, I should be able to override the login screen URL

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/448/ --- Review request for Viewer. Summary --- Made it possible to override lo

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/#review987 --- These changes don't apply to the v-d tip. Please create a fresh fo

Re: [opensource-dev] Review Request: STORM-555 As a LL developer, I should be able to override the login screen URL

for pointing out. - Vadim On Aug. 22, 2011, 9:29 a.m., Vadim ProductEngine wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondli

Re: [opensource-dev] Review Request: STORM-1543 During busy mode inventory offers get silently deleted instead of thrown into trash

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/444/ --- (Updated Aug. 25, 2011, 2:23 p.m.) Review request for Viewer and Richard Ne

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/#review993 --- indra/newview/lltoastnotifypanel.cpp

[opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/ --- Review request for Viewer. Summary --- Reason: Showing the confirmatio

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/ --- (Updated Aug. 26, 2011, 8:38 a.m.) Review request for Viewer and Seth Produ

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

> On Aug. 26, 2011, 6:05 a.m., Vadim ProductEngine wrote: > > indra/newview/llviewermessage.cpp, lines 6556-6559 > > <http://codereview.secondlife.com/r/449/diff/2/?file=6988#file6988line6556> > > > > It's a hack to update the Block List panel fro

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

-- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/#review997 --- On Aug. 26, 2011, 8:38 a.m., Vadim ProductEngine wrote: > > --

Re: [opensource-dev] Review Request: STORM-638 "Object Return" doesn't return distant objects

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/ --- (Updated Aug. 27, 2011, 3:01 a.m.) Review request for Viewer and Seth Produ

Re: [opensource-dev] Review Request: STORM-1567 Mute button for llDialog popup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/449/#review1000 --- Ship it! - Vadim On Aug. 26, 2011, 9:37 a.m., Jonathan Yap wro

[opensource-dev] Review Request: STORM-1028 Speak button label not displaying at default window size

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/453/ --- Review request for Viewer. Summary --- Changes: - Make sure we initial

Re: [opensource-dev] Review Request: STORM-1028 Speak button label not displaying at default window size

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/453/ --- (Updated Aug. 30, 2011, 4:51 a.m.) Review request for Viewer. Summary (up

Re: [opensource-dev] Review Request: STORM-1532 (was VWR-25923) followup: Unnecessary capability request spam

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/452/#review1003 --- Ship it! Looks plausible to me. - Vadim On Aug. 30, 2011, 2:2

[opensource-dev] Review Request: STORM-1297 Clicking on Block in a dialog box from an object blocks by name

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/454/ --- Review request for Viewer and Jonathan Yap. Summary --- Block object i

[opensource-dev] Review Request: STORM-1576 Show button does not work in Inventory offer toast

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/455/ --- Review request for Viewer. Summary --- Fixed the button index, which b

Re: [opensource-dev] Review Request: storm-1578: change default Away timeout to never

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/459/#review1007 --- Ship it! - Vadim On Aug. 31, 2011, 7:29 a.m., Oz Linden wrote:

[opensource-dev] Review Request: STORM-918 Changes in Group Role Titles or Assignments Not Reflected in Title Dropdown

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/461/ --- Review request for Viewer and Paul ProductEngine. Summary --- Changes:

[opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/464/ --- Review request for Viewer and Oz Linden. Summary --- Removed usage of

[opensource-dev] Review Request: STORM-1587 A lot of notifications are shown in English for other locales in 3.0.3 Beta

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/465/ --- Review request for Viewer. Summary --- Make sure LLUI::setupPaths() ge

[opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/466/ --- Review request for Viewer and Seth ProductEngine. Summary --- Replaced

[opensource-dev] Review Request: STORM-1585 Duplicated XUI ID: floater_preferences_proxy.xml

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/467/ --- Review request for Viewer and Log Linden. Summary --- Fixed duplicated

Re: [opensource-dev] Review Request: check_mark.png not loading at startup

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/468/#review1020 --- Ship it! - Vadim On Sept. 13, 2011, 12:07 a.m., Tankmaster Fin

Re: [opensource-dev] Review Request: OPEN-112 Windows debug build fails at run time because of an absent openjpeg.dll.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/445/ --- (Updated Sept. 13, 2011, 5:10 a.m.) Review request for Viewer. Summary (u

[opensource-dev] Review Request: STORM-1595 Crash in developer builds when changing selection in detached sidebar inventory panel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/469/ --- Review request for Viewer. Summary --- Removing a wrong debug assertio

[opensource-dev] Review Request: STORM-1597 Inventory Window "object profile" warped when Inventory Window is a resized floater

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/470/ --- Review request for Viewer. Summary --- The Back button int the object

[opensource-dev] Review Request: STORM-1599 Unexpected camera zoom occurs if scroll search history drop-down list by mouse wheel

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/471/ --- Review request for Viewer. Summary --- Trivial fix: don't pass mouse w

Re: [opensource-dev] Review Request: STORM-1577 Convert chat translation to third party paid translation services (take 2)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/466/ --- (Updated Sept. 15, 2011, 2:57 p.m.) Review request for Viewer and Seth Prod

[opensource-dev] Review Request: STORM-1600 Error in focus while naming a new item - may lead to content loss

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/478/ --- Review request for Viewer and Richard Nelson. Summary --- Folder view

[opensource-dev] Review Request: STORM-1611 Untrusted link to server release notes

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/481/ --- Review request for Viewer. Summary --- Fetch server release notes URL

[opensource-dev] Review Request: STORM-1603 Investigate Classifieds' Cap on pricing

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/482/ --- Review request for Viewer. Summary --- Increased max classified price

[opensource-dev] Review Request: STORM-1614 Untranslatable gesture: /bow

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/483/ --- Review request for Viewer. Summary --- Backing out the "fix" of STORM-

[opensource-dev] Review Request: STORM-1612 Click-to-walk in Advanced mode

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/485/ --- Review request for Viewer. Summary --- Changes: * Click and double cli

Re: [opensource-dev] Review Request: Statistic floater update

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/486/#review1038 --- Ship it! LGTM - Vadim On Sept. 26, 2011, 1:43 p.m., Tankmaste

Re: [opensource-dev] Review Request: Enable legacy viewer C++ tests in indra/test.

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/479/#review1039 --- Ship it! - Vadim On Sept. 19, 2011, 12:23 p.m., Log Linden wro

Re: [opensource-dev] Review Request: STORM-1612 Click-to-walk in Advanced mode

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/485/ --- (Updated Sept. 29, 2011, 5:40 a.m.) Review request for Viewer. Changes --

[opensource-dev] Review Request: STORM-1615 Please update language support for Viewer

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/490/ --- Review request for Viewer and Richard Nelson. Summary --- - Added Trad

Re: [opensource-dev] Review Request: STORM-1615 Please update language support for Viewer

lation would be a good fit. - Vadim --- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/490/#review1049 --- On Oct. 11, 2011,

[opensource-dev] Review Request: STORM-1666 Redundant "Release Notes" text in the About window for non-English locales

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/505/ --- Review request for Viewer. Summary --- Ported the XML changes made for

[opensource-dev] Review Request: STORM-1667 Square brackets around of Release Notes link in the About window

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/506/ --- Review request for Viewer. Summary --- Adding back code that was accid

[opensource-dev] Review Request: STORM-1668 Localized strings.xml contains reference to non-existing gesture "bow1"

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/507/ --- Review request for Viewer. Summary --- Fixed references to nonexistent

Re: [opensource-dev] Review Request: STORM-1105 "Traffic: 0" shown for two cases (traffic actually 0, and waiting for data)

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/509/#review1070 --- Ship it! - Vadim On Oct. 28, 2011, 4:34 a.m., Jonathan Yap wro

[opensource-dev] Review Request: STORM-1676 "powered by Google" text is shown in the Nearby chat window when Bing translation service is used

--- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/511/ --- Review request for Viewer. Summary --- Removed "Powered by Google" lab

<    1   2   3