> On Aug. 26, 2011, 11:51 a.m., Richard Nelson wrote: > > indra/newview/llviewermenu.cpp, line 4267 > > <http://codereview.secondlife.com/r/451/diff/2/?file=7032#file7032line4267> > > > > This is dangerous! Never hold on to raw pointers to llviewerobject, as > > they can be deleted from under you. Use LLPointer instead. > > > > I looked into fixing the underlying problem, but that involves > > revisiting the design of selections. We always deselect objects beyond a > > certain distance in order to keep your avatar proximate to the objects you > > can affect (for various technical and social reasons). This workaround is > > fine for now, if not ideal.
Ah, crap. I was going to use an LLPointer but forgot then. Thank you very much for spotting, will fix! - Vadim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/451/#review997 ----------------------------------------------------------- On Aug. 26, 2011, 8:38 a.m., Vadim ProductEngine wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/451/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2011, 8:38 a.m.) > > > Review request for Viewer and Seth ProductEngine. > > > Summary > ------- > > Reason: Showing the confirmation dialog resets object selection, > thus there is nothing to derez. > > Fix: Save selection until user answers in the confirmation dialog. > > I didn't investigate why the bug occurred only for distant object > (must be some internal LLSelectMgr magic). > > > This addresses bug STORM-638. > http://jira.secondlife.com/browse/STORM-638 > > > Diffs > ----- > > indra/newview/llviewermenu.cpp 64ed6f9362af > > Diff: http://codereview.secondlife.com/r/451/diff > > > Testing > ------- > > See acceptance criteria in the JIRA ticket. > > > Thanks, > > Vadim > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
